-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata: Use creation time from Google Photos JSON sidecar file #2133
Comments
Since it seems nobody has yet taken a look at this I'd be happy to give it a shot, how would I go about implementing this? I took a look at the metadata scripts and they seem pretty straightforward, just not sure how to make it so it prioritizes one over the other. |
Do we have an example file for testing? Our parser currently reads the time from |
@ADawesomeguy You (and others) are welcome to do research and document the results so we can implement this! Changing the code is quite easy, just checked it - but we need to avoid creating a mess with inconsistent data for everyone. Testing in our users' production environments is not an option. |
Awesome, thanks for the info! I'll definitely take a look when I have time. |
this README has some info about Google Takeout exports that might be helpful |
It's been a while but I'll give this a shot. If anyone else wants to step in and give it a look at some point that would be cool too. |
Alright I've delved a bit deeper and was wondering where exactly the code is that I should change? In addition, would this be a frontend modification (changing the displayed date) or a backend modification (changing the metadata) or something else? |
I want to add a note of consideration here: please do not store the photo time in UTC as Google Photos provides it. As a user, the original timezone of the photo is very important information because in most cases I just want to know the time of the photo in the local time it was taken. If I take a trip abroad and take photos, I do NOT want those photos' times to be stored in UTC. When I look at the photos, I want to see "Taken at 7:09pm" (the time in the abroad timezone the photo was taken in), NOT "Taken at 4:09am" (the time the photo was taken in, stored in UTC). Since Google Photos stores photo times in UTC, we should first get the local offset of the photo time via the In the absence of a time offset in a photo that has datetime metadata, I think we should disregard Google Photo's UTC time because using it would mean no way of getting back to the local time the photo was taken it, which will result in a "wrong" photo time to the user who just cares about seeing the photo time in the timezone it was taken. In the absence of any temporal photo data at all (if not in the metadata, maybe in the file name), I suppose the best we can do is just go ahead and use Google Photo's UTC time. Edit: actually I think now I see that in the scope of this issue, we are not talking about ever writing to the file itself, but instead writing to wherever PhotoPrism stores metadata. I have updated the message body to reflect this realization. |
Here is some data that may help with testing:
|
As a Google Photos user who has updated the capture time/date, I would like PhotoPrism to import the corrected date from the GPhotos JSON sidecar files instead of the (possibly incorrect) original exif date.
Implementation requires further investigation:
Acceptance Criteria:
photoTakenTime
from Google Photos JSON files MUST be prioritized over data found directly in Exif file headersThe text was updated successfully, but these errors were encountered: