-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata: Fault-tolerant parsing of timestamps from Exif and JSON sidecar files #625
Comments
You can enter "1993-00-00 12:00:00" with Exiftool and that works in all software? 00 is not a valid month, so typical date parsers will report an error. We would also have to set it to 01 internally as the database will not store it otherwise. |
Hello |
Batch edit will be implemented for sure, after our release so that users don't have to wait any longer :) |
Nice! Can't wait. |
I like the idea of incomplete dates. Currently this function is used to check for a valid exif datetime. It is missing checks for partial datetimes: photoprism/internal/meta/exif.go Line 36 in bc86997
In fact this could be a good be a good beginner task, so I might find some time to implement this. |
With these improvements, PhotoPrism should be able to parse any timestamps matching the following patterns regardless of the delimiters or missing values (as long as they make sense, e.g.
Help with testing would be greatly appreciated! A new development preview build has been started... |
Hello
|
Just pulling the preview image is not enough, you also need to change the image name in your Stable Version (default in our config example): services:
photoprism:
## Use photoprism/photoprism:preview for testing preview builds:
image: photoprism/photoprism:latest Development Preview: services:
photoprism:
## Use photoprism/photoprism:preview for testing preview builds:
image: photoprism/photoprism:preview After you have changed the tag name, be sure to properly restart your instance as described in our docs: docker-compose pull
docker-compose stop
docker-compose up -d |
Would it be better to assume 12:00 (lunchtime) when there is no specific time provided? |
For me personally, this is not very important. I don't know if there are more or less universal conventions. |
I would say 00:00 is fine. That way it is obvious that the image did not contain a hour. |
I will probably reset the database and reindex all of my photos. I expect to lose some metadata. I would like if possible not to re-enter a number of dates.
In many scanned photos, I have defined the Date/Time Original field with exiftool. When the date is complete, it is taken into account by PhotoPrism. On the other hand, if there is only part of the date (year, or year + month for example), it is totally ignored, whereas we would like the year to be taken into account and the month and / or the day is declared Unknown
I tried with this one for example:
but without success.
Behind this subject, there is a significant time saving because with exiftool I can put a date, even incomplete, in dozens of photos at a time, while with PhotoPrism, you have to manually go through each of them, and operate 3 changes (year / month / day)
Well, at least as long as there isn't a way to apply the same change to several photos.
The text was updated successfully, but these errors were encountered: