Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: "Unknown country" filter has no effect #3412

Closed
dror3go opened this issue May 17, 2023 · 6 comments
Closed

Search: "Unknown country" filter has no effect #3412

dror3go opened this issue May 17, 2023 · 6 comments
Assignees
Labels
bug Something isn't working released Available in the stable release

Comments

@dror3go
Copy link

dror3go commented May 17, 2023

Using the latest release 230514-0b780defb - manually setting coordinates of pictures without GPS data in their exif and filtering by unknown country still shows these pictures, even though when opening them - they have a country set in the UI.

Note that this wasn't the behavior in older releases - I'm using the "unknown country" filter a lot in order to tag (mostly) older pictures without GPS data.

@lastzero
Copy link
Member

If this has changed, it could be that a user requested it previously. Could you check our commit/change log as well as the closed GitHub issues for this?

@lastzero lastzero added help wanted Well suited for external contributors! idea Feedback wanted / feature request labels May 17, 2023
@dror3go
Copy link
Author

dror3go commented May 17, 2023

Oh wait, it seems that all pictures are being returned when filtering by unknown country, meaning also pictures with GPS information.

I wasn't able to find a relevant note about this in the changelog.

@graciousgrey
Copy link
Member

I will take a look at that tomorrow, thank your for reporting.

@lastzero
Copy link
Member

lastzero commented May 17, 2023

Unknown country should find pictures with country code "zz" and/or place ID "zz" if I remember correctly.

Edit: Could it be a problem with retrieving the data from our geocoding API so that the coordinates cannot be resolved?

@dror3go
Copy link
Author

dror3go commented May 17, 2023

I'm not familiar with the implementation - but I'd imagine that the geocoding API is being used when indexing a new picture or when tagging lat/lon, and not upon search. Right? The database and the UI shows the correct country, but the filter seems broken.

Also reproduced the issue in the demo website using the 20230517_111654_F26B14AA file that was there.

@lastzero lastzero added bug Something isn't working and removed idea Feedback wanted / feature request labels May 17, 2023
@lastzero lastzero self-assigned this May 17, 2023
@lastzero lastzero changed the title Pictures with manually entered coordinates are being shown when filtering by unknown country Search: "Unknown country" filter has no effect May 17, 2023
@lastzero lastzero removed the help wanted Well suited for external contributors! label May 17, 2023
lastzero added a commit that referenced this issue May 17, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this issue May 17, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero added the please-test Ready for acceptance test label May 17, 2023
@dror3go
Copy link
Author

dror3go commented May 18, 2023

Fixed, thanks! 👏

@lastzero lastzero added tested Changes have been tested successfully and removed please-test Ready for acceptance test labels May 19, 2023
@lastzero lastzero added released Available in the stable release and removed tested Changes have been tested successfully labels Jun 3, 2023
@lastzero lastzero closed this as completed Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

3 participants