New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Albums: Set cover image for album/calendar/folder/moment/state/person #383
Comments
We automatically use the most recent one with the highest relevance right now (favorite, most recent, good resolution, complete metadata). We can later add a dialog to manually set a specific image, but we also need a fallback if that photo was removed / deleted. |
I think I tried setting a favourite and it didn't appear to update immediately, but maybe there is a delay or the other photo was still ranked higher somehow? |
Yes, we cache the photo as the query is quite expensive. An improvement would be to detect changes and clear the cache so that they become visible immediately. |
Hi! is still not possible to choose a specific photo to set up the thumbnail for an album? |
@AbucoAnd No, that's why the issue is still open ;) There are tons of feature requests, can't do everything at the same time. You can support us by becoming a sponsor. |
thanks for the quick reply @graciousgrey ! much appreciated! As soon as I decide if I finally use Photoprism, I will make a donation to support you ^^ Also I would like to know if is there any way to "customize" the app or it's not legal? |
@AbucoAnd You can choose between several themes already (https://docs.photoprism.app/user-guide/settings/general/). In addition you can customize the app by editing the environment variables (https://docs.photoprism.app/getting-started/config-options/#web-app) |
Hey @graciousgrey , what would be the table and query to update such information? I'd happily do so in the meantime. The work you people are doing with this software is amazing. I am extremely happy for it. My family gallery is now all organised and with face recognition, and the places section is just so good too! Love you all 🤗 |
Thanks a lot for your feedback :) To update the cover image in the database:
|
Appreciate the pointer! I wanted to update a face "album" instead, which was a bit more fiddly, but ended up working for me:
The only unknown thing to me is the extra little hash after the photo hash, which identifies the specific person you are after amongst the many people's faces. Perhaps you can clarify a bit more for me here (also, if there is any way to find such hash, instead of using developer tools) Thank you again!! 🙏 |
For normal album the whole image is used as cover. For subjects only a cropped portion of the photo is used. This crop has a different hash. |
Is there a way to clear just that one thumb from the server side cache or would I need to clear the entire cache? Any hints how to do that would be much appreciated. Thank you for all your hard work |
This should happen when you change the private flag of a related picture. So maybe you can trigger it with that, even when you have manually manipulated the database. |
So I ran the following SQL query to change the private flag on all photos in a specific album (approx 3500 photos): UPDATE and after that one of the pictures was still stuck as a thumbnail on the album cover. What I tried was:
I will see if I can re-create this scenario again |
Could you please illustrate how this is done? I'm trying to change the thumb on something, but I can't find the hash of the thumb. I looked in developer tools in the browser but couldn't find it. |
This is the SHA1 checksum for full images. For face crops, it is extended with information about the area: https://github.com/photoprism/photoprism/tree/develop/internal/crop |
Hi, I've just come across this when setting up my library. Are we still expected to modify the database to set album key photos? Thanks |
We haven't had any resources left to work on it yet. |
No worries, I was just curious if it was ever addressed. Unfortunatley for me, it seems to occasionally reset the album thumb (to the most recent image hash) as I use Photo Prism. |
You can't get new users if you don't add basic features. You can't add basic features unless you gain new users. They both come hand-in-hand, a 3-year old basic function should have been addressed by now. |
As much as I would love to see this feature being implemented. It is unfair to talk to the maintainers and creators of this project in the way you are doing. "Should have been addressed", maybe if this was contractually set in stone, but that ain't the case. This is an open source project and we should be glad it exists and we can use it for free. |
I enjoy PhotoPrism very much and my rudeness was unwarranted. I apologize for my tone and comments. I only want to see this software progress and to reach its full potential. I will keep my emotions in check. |
Is there still a way to set a "People" cover photo? Ive tried extact hash from DOM but after DB update it just shows emty cover. style="background-image: url("http://photoprism.lan:2342/api/v1/t/hashA-hashB/1c3n4otv/tile_320"); background-position: center center; Ive tried both hashA, hasAhashB, as a thumb in subjects table with no luck. |
In the subjects table, you need to set "thumb" to "hashA-hashB" and "thumb_src" to "manual". After you submit your changes, the cover will be updated. Next time you need help or if there are further question, please post your question in GitHub Discussions or ask in our Community Chat. Thank you very much! |
Thanks for the reply. Last message here. |
For information: I have been playing around with this in a dev box recently and now I am able to set the album covers via the "Edit Album"-form. However, I would like to beautify my solution a bit to make it more user friendly / sturdy prior to considering creation of a pull request. Let me try to find some time for this in the coming period. Furthermore, I assume the solution can be copy / pasted to other entities but I have not looked into this yet as for me setting thumbnails for albums is the main missing feature (as usually I share albums with interested people, not other entities). |
I spend a bit more time to make thumbnail selection easier by actually showing the thumbnail itself in a dropdown field (using tile_50). The code is working in major browsers, but might benefit from some (relatively simple) refactoring by the team on merge as I assume they have significantly more knowledge on the Vuetify framework :). Let me see if I can wrap things up for the selection for Albums and create a clean pull request in the coming period. |
That looks great! Of course, we still need to test it and can't merge it until it's (almost) ready for production. Note that some users have very large albums with thousands of pictures - so those shouldn't break the UI. |
I would love to see that interface but I wonder if it would be better to use the regular photo selection to do this.
I think the main downside is that it is a little multi-select focused. But I think that it would be fine to have this option appear only if one photo is selected. |
I was a bit worried that adding another icon could be confusing (the first time I opened PhotoPrism I needed to 'figure out' what some of the icons are used for). But let me explore the option a bit as I also do see the benefits you mention. |
Yeah. That's a good point, there are already too many icons there if you ask me. But I think that is a problem that needs to be solved anyways. There is going to be a need for more actions. Maybe an overflow menu or some other interface would help. However it seems to me that adding another action list is the right approach. If that means that the action list can then be improved it may theb make sense to do that. But I'm not actually in charge here so 🤷 |
As you both say, adding more options to the existing context menu is not an ideal solution and we prefer not to do that, also because there is not enough space on smaller mobile devices. There is definitely a need for more actions and we have already thought about adding an additional menu (maybe in the toolbar), we just haven't had time to experiment with it yet. |
I guess my point is that using a worse UX to work around a problem that is going to be fixed anyways seems suboptimal. But maybe if we want to get this feature shipped soon that is what we need to do. |
I do recon the point of @kevincox, but I think it is not up to me to redesign the context menu of the viewer as part of this feature implementation. The back end changes I made (and the logic used for the front end) can probably be reused should the solution be moved to this menu at a later moment in time. With above in mind I did some quick tests on my implementation to check scaling: it appears lazy-loading of Vuetify is working properly. Having an album of approx. 70 images shows that half the thumbnails are loaded when opening the "Edit Album"-dialog, while the remainder is loaded when scrolling through the selection list (they are probably below the fold prior to scrolling). I will try to create a test set of approx. 1000 images to see how the GUI reacts to such an amount on both desktop and mobile. That should cover the majority of use cases and I hope the solution is still well responsive with this amount :). Update: No issues with 800 images on a desktop. I will expand the set and check some other device / browser configurations. |
I created an album with 4975 pictures and tested functionality in Edge, Chrome and FireFox. They all work fine with a minor delay before populating the options in the field due to the full list being received from the server: for me the delay is acceptable as I believe most albums will probably be smaller (potentially in contrast to folders) and it's still short. I will do some final clean-up / code tweaking before testing in above browsers and mobile formats. Once OK, I will look into the creation of a clean pull request. |
I am creating a pull request for this feature (for Albums) as I have updated translations and did a last pending bugfix (Vuetify Select is not neatly working with long option labels; alternative to CSS implementation is to truncate the photo names in JS). The final implementation looks as follows: As a performance security measure the selection box will load maximum 10.000 photos from an Album. Similar logic has been implemented in PhotoPrism earlier to maximize the amount of Albums that can be displayed (here). Obviously, this logic can be removed if considered more convenient. |
@Xirt |
It took me a while to find this issue because I was searching for "key photo" instead of "cover image" or "primary photo". This comment is just meant to add to the list of synonyms for this feature. |
It looks like (apart from Stacks which have a 'primary' photo) it isn't possible to set the hero image for a collection of photos (e.g. Album, Calendar month 'Album', Moment, Folder).
Some ideas:
The text was updated successfully, but these errors were encountered: