-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set cover image for album/calendar/folder/moment #924
Conversation
@lastzero I think I am mostly done, would you mind taking a look. Tests and translations are missing, tests should be doable, but I am not sure how to handle the translations? Should I wait until someone translates it into every supported language? Do I just translate it with DeepL? |
@lastzero Did you had a chance to take a look? |
@kvalev I checked out your branch (cover-image) to test. I see the button in the UI but the album cover is not updated for me and I get no error |
If you refresh the page (browser reload, not pp reload) you should see the updated cover. For some reason pp does not fetch the updated covers for a page, which was already visited (e.g. going from |
Ok, I can confirm it works when reloading and emptying the cache of the browser. Thanks for your work! I still see the following to dos:
|
This includes albums/moments/calendar/states/folders.
The first two are done. The third one should be fairly easy, but it requires extending the database schema and my understanding is that you prefer not to make any database changes at this time. |
Thank you! I will have a look later today or tomorrow :) |
Functionality looks good :) @lastzero will have a look at the code as well as soon as possible, we need to find out why the build is failing Thanks for your work! |
The failing build has been fixed |
Thank you, unfortunately we won't find time in March. In the meantime you can send us an email to hello@photoprism.app so that we can send you instructions on how to enable sponsor/contributor features, if you like :) |
We have thumb columns in our database for this now, so that no UID lookup is required anymore, plus you can set a custom cover if you change the src to any value <> '' |
Hi! What about this PR? I am looking for this functionality too. What was the issue with the branch/commits?
@lastzero you mean directly in the database, right? |
@q3flat The problem is missing time and resources. We have high quality standards and merging pull requests requires a lot of work and time on our side.
We would love to grow our team to be able to work faster but we can't even cover our own expenses yet --> https://github.com/sponsors/photoprism To set a cover image in the database, you need to add the filehash of the file you want to have as cover in the "thumbs" column. Additionally you need to set "thumb_src" to "manual". |
Check out the Release Notes if you wonder why we didn't have time yet: |
Thanks for the responses! I understand that. So technically PP is capable of this "feature" by now. It is great for me. Thanks! (My previous nickname was q3flat) |
Tasks:
Closes #383