Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPEG: Fix regression when handling files with EOF error #3855

Closed
lastzero opened this issue Oct 31, 2023 · 1 comment
Closed

JPEG: Fix regression when handling files with EOF error #3855

lastzero opened this issue Oct 31, 2023 · 1 comment
Assignees
Labels
bug Something isn't working released Available in the stable release tested Changes have been tested successfully

Comments

@lastzero
Copy link
Member

Due to changes in our JPEG image library, the error message for files with EOF errors has changed, so that e.g. panoramas taken with a Samsung S21 could not be indexed anymore:

@lastzero lastzero added the bug Something isn't working label Oct 31, 2023
@lastzero lastzero self-assigned this Oct 31, 2023
lastzero added a commit that referenced this issue Oct 31, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero added the please-test Ready for acceptance test label Oct 31, 2023
@lastzero
Copy link
Member Author

We now check if "EOF" is contained anywhere in the error message, not just at the beginning. Unless the error changes completely in future library versions, this should prevent further regressions. An updated preview build will be available for testing soon!

@graciousgrey graciousgrey added tested Changes have been tested successfully and removed please-test Ready for acceptance test labels Nov 21, 2023
@graciousgrey graciousgrey added the released Available in the stable release label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release tested Changes have been tested successfully
Projects
Status: Release 🌈
Development

No branches or pull requests

2 participants