Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Improve Accessibility / Enable Page Zoom #799

Open
Jab2870 opened this issue Jan 3, 2021 · 7 comments
Open

UX: Improve Accessibility / Enable Page Zoom #799

Jab2870 opened this issue Jan 3, 2021 · 7 comments
Assignees
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release ux Impacts User Experience

Comments

@Jab2870
Copy link

Jab2870 commented Jan 3, 2021

Hi,

I see that commit b716935 disables page
zooming. As someone who makes heavy use of this feature, would you consider
undoing the change? For people who have weak eyesight, this change could cause
significant issues.

The ability to increase the size of everything is, for me, a huge advantage that
web apps provide over native.

Here are a few resources that you might find helpful

https://www.a11yproject.com/posts/2013-01-14-never-use-maximum-scale/
http://www.javierusobiaga.com/blog/stop-using-the-viewport-tag-until-you-know-ho/

@lastzero
Copy link
Member

lastzero commented Jan 3, 2021

Someone else asked for this. Guess we'll add yet another config flag! Thanks for letting us know :)

@lastzero lastzero added the enhancement Refactoring, improvement or maintenance task label Jan 3, 2021
@lastzero lastzero self-assigned this Jan 3, 2021
@lastzero
Copy link
Member

lastzero commented Jan 3, 2021

@Jab2870 Are there additional accessibility features we may implement to make using PhotoPrism easier for you?

@lastzero lastzero changed the title Re-enable page zoom UX: Improve Accessibility / Enable Page Zoom Jan 3, 2021
@Jab2870
Copy link
Author

Jab2870 commented Jan 3, 2021

Hi @lastzero,

I have noticed that when tabbing through the application, it is not always clear
which elements currently have focus. However, if you like, I will create a
separate issue for that.

@lastzero
Copy link
Member

lastzero commented Jan 3, 2021

Sounds like this is more work, also I'm not sure how much influence we have on this since we're using a UI framework.

Maybe you (or some one else) finds something in the docs: https://v15.vuetifyjs.com/en/getting-started/quick-start

@lastzero
Copy link
Member

lastzero commented Jan 3, 2021

Let us know if there are any obvious "quick wins", like the zoom. Might be able to implement those as part of this issue.

@Jab2870
Copy link
Author

Jab2870 commented Jan 3, 2021

I used to be a front end dev although I haven't done much with vuetify. I will
have a read through the docs and let you know, might be able to make some pull
requests for you as well although it probably won't be until next weekend now.

@lastzero
Copy link
Member

lastzero commented Jan 5, 2021

You may now change this in config/settings.yml - we'll also add Accessibility settings to our UI but in a later release as it requires translations & documentation.

See https://github.com/photoprism/photoprism/releases/tag/210104-7f9e806a

@lastzero lastzero added the please-test Ready for acceptance test label Jan 5, 2021
@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels Feb 8, 2021
@lastzero lastzero added the ux Impacts User Experience label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release ux Impacts User Experience
Projects
Status: Release 🌈
Development

No branches or pull requests

3 participants