Sharing: Fix app navigation layout on small screens #2430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There exists a css-class to make sure that on small screens, there is space above the content for the nav-bar.
This is only relevant for small screens, because on wide screens the navigation is on the left side.
wether a nav-bar is shown or not can be configured in the
routes.js
on a per-route basis by either providing or not providingmeta: {hideNav: true}
.This setting controls wether the
show-nav
-class (and therefore the 48px padding on small screens) gets applied or not.Or in short: routes that don't have a navigation must have
meta: {hideNav: true}
set, otherwise there is blank space above the content on small screens, that looks like this:The shared album views do not have a navigation, and therefore require this config. They are currently not configured correctly, resulting in the bug displayed above. This PR fixes that.
Acceptance Criteria: