Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing: Fix app navigation layout on small screens #2430

Conversation

heikomat
Copy link
Sponsor Contributor

@heikomat heikomat commented Jun 16, 2022

There exists a css-class to make sure that on small screens, there is space above the content for the nav-bar.
This is only relevant for small screens, because on wide screens the navigation is on the left side.

wether a nav-bar is shown or not can be configured in the routes.js on a per-route basis by either providing or not providing meta: {hideNav: true}.
This setting controls wether the show-nav-class (and therefore the 48px padding on small screens) gets applied or not.

Or in short: routes that don't have a navigation must have meta: {hideNav: true} set, otherwise there is blank space above the content on small screens, that looks like this:

without fix with fix
Screenshot 2022-06-16 at 20 11 07 Screenshot 2022-06-16 at 20 08 48

The shared album views do not have a navigation, and therefore require this config. They are currently not configured correctly, resulting in the bug displayed above. This PR fixes that.

Acceptance Criteria:

  • Features and improvements are fully implemented so that they can be released at any time without additional work
  • Automated unit and/or acceptance tests have been added to ensure the changes work as expected and to reduce repetitive manual work
  • User interface changes are fully responsive and have been tested on all major browsers and various devices
  • Database-related changes are compatible with SQLite and MariaDB
  • Translations have been / will be updated (specify if needed)
  • Documentation has been / will be updated (specify if needed)
  • Contributor License Agreement (CLA) has been signed

@heikomat heikomat changed the title fix shared albums having space for non-existent nav-bar above content fix shared albums having space for non-existent nav-bar above content on small screens Jun 16, 2022
@lastzero lastzero merged commit 08b6b2d into photoprism:develop Jun 17, 2022
@lastzero lastzero added frontend Requires experience with HTML/JS/CSS bug Something isn't working labels Jun 17, 2022
@lastzero lastzero changed the title fix shared albums having space for non-existent nav-bar above content on small screens Sharing: Fix app navigation layout on small screens Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Requires experience with HTML/JS/CSS
Projects
Status: Release 🌈
Development

Successfully merging this pull request may close these issues.

None yet

2 participants