Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPEG: Automatically fix files with missing EOI marker #2721

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

AlD
Copy link
Contributor

@AlD AlD commented Sep 19, 2022

Fixes #2463

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2022

CLA assistant check
All committers have signed the CLA.

@lastzero
Copy link
Member

My apologies for not getting back to you sooner! This looks good at first sight. One potential issue could be higher memory usage when a file must be "repaired", if I understand it correctly?

@lastzero lastzero self-assigned this Jun 27, 2023
@lastzero lastzero added the enhancement Refactoring, improvement or maintenance task label Jun 27, 2023
@lastzero lastzero changed the title Attempt to repair JPEGs with missing EOI marker JPEG: Automatically fix files with missing EOI marker Jun 27, 2023
@lastzero lastzero added in-progress Somebody is working on this waiting Impediment / blocked / waiting and removed in-progress Somebody is working on this waiting Impediment / blocked / waiting labels Jun 27, 2023
@lastzero lastzero merged commit da61515 into photoprism:develop Jun 29, 2023
@lastzero lastzero added please-test Ready for acceptance test merged Changes should be tested again after they have been integrated labels Jun 29, 2023
@maxime1992
Copy link

Thanks a lot @AlD for the PR! This issue has been crippling my workflow with photoprism where I run a check and fix command on Linux first on all photos before uploading... That'll be tremendously helpful ❤️ 🙏 !

lastzero added a commit that referenced this pull request Jun 29, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero
Copy link
Member

@maxime1992 Could you please test it again with our latest preview build? Thank you very much! 🙏

If you still have problems with some JPEG files, feel free to share them with us so we can fix the remaining issues for you:

Note that we will be on vacation for the first two weeks of July, so responding to emails may take longer than usual.

@maxime1992
Copy link

@lastzero I just tried the preview with the image I shared in my original issue and it worked straight away! Amazing :)

@lastzero lastzero removed the please-test Ready for acceptance test label Jun 30, 2023
@maxime1992
Copy link

@lastzero I see you added the label "please-test". Not sure you've seen my message above but I did test it and can confirm it works ✔️

@lastzero lastzero added the tested Changes have been tested successfully label Jun 30, 2023
@lastzero
Copy link
Member

I've actually removed the label :) Thanks for testing!

lastzero added a commit that referenced this pull request Jul 18, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero added released Available in the stable release and removed tested Changes have been tested successfully merged Changes should be tested again after they have been integrated labels Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release
Projects
Status: Release 🌈
Development

Successfully merging this pull request may close these issues.

JPEG: Automatically check and repair broken/invalid images
5 participants