-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JPEG: Automatically fix files with missing EOI marker #2721
Conversation
My apologies for not getting back to you sooner! This looks good at first sight. One potential issue could be higher memory usage when a file must be "repaired", if I understand it correctly? |
Thanks a lot @AlD for the PR! This issue has been crippling my workflow with photoprism where I run a check and fix command on Linux first on all photos before uploading... That'll be tremendously helpful ❤️ 🙏 ! |
Signed-off-by: Michael Mayer <michael@photoprism.app>
@maxime1992 Could you please test it again with our latest preview build? Thank you very much! 🙏 If you still have problems with some JPEG files, feel free to share them with us so we can fix the remaining issues for you: Note that we will be on vacation for the first two weeks of July, so responding to emails may take longer than usual. |
@lastzero I just tried the preview with the image I shared in my original issue and it worked straight away! Amazing :) |
@lastzero I see you added the label "please-test". Not sure you've seen my message above but I did test it and can confirm it works ✔️ |
I've actually removed the label :) Thanks for testing! |
Signed-off-by: Michael Mayer <michael@photoprism.app>
Fixes #2463