json_encode on empty Map returns array

[petr-buchin]

I was glad to see, that Map data structure can be json-encoded.
But if you run json_encode() on empty map, it gets gets encoded as an array - [].
I think this is a bug, since Map should always be encoded as an object - {}.

Thank you very much in advance!

[rtheunissen]

This is unfortunately how JsonSerializable works, where jsonSerialize returns the native value to be encoded to JSON.

The method in the extension is implemented to delegate it to an array:

METHOD(jsonSerialize)
{
    PARSE_NONE;
    ds_map_to_array(THIS_DS_MAP(), return_value);
}

Actually, we can cast that to an (object) which would encode as {}. It's unfortunate that this is O(n) to convert the map to an array first, then O(n) again to encode to JSON. I'd like to look into the possibility of a toJson method that interacts directly with a JSON api of some kind.

I'll try the object cast in the meantime - thanks for brining this up.

[rtheunissen]

I think this should do it. 078243f

[petr-buchin]

Thank you very much!

[rtheunissen]

This has now been fixed and released as part of 1.3.0