Fixes timeout in messages #1171
Conversation
My understanding is that the old code would have an exponential decay. Basically, it would subtract the amount of seconds that had elapsed since the code started executing with each attempt. This would mean that a retry after two seconds would subtract 2 seconds from the timeout, a retry after 5 seconds, would remove another 5 seconds.
There was another use of `$thisTimeout` that I missed.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Is there an issue with this code? |
|
I don't see an issue with existing implementations coming into play. If somebody requested a timeout of 60 seconds for their application the only side-effect of this code would be that the application is a bit more patient. Since the old timeout would decay too fast. It may slow somebody's application down, but it's definitely not going to cause it to behave poorly. Meanwhile, somebody expecting their application to wait 60 seconds and getting a timeout after 30 could be a potential issue for an application. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
My understanding is that the old code would have an exponential decay. Basically, it would subtract the amount of seconds that had elapsed since the code started executing with each attempt.
This would mean that a retry after two seconds would subtract 2 seconds from the timeout, a retry after 5 seconds, would remove another 5 seconds.