Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit nullable types to PSR-17 #1321

Merged
merged 1 commit into from
May 10, 2024
Merged

Add explicit nullable types to PSR-17 #1321

merged 1 commit into from
May 10, 2024

Conversation

alexandre-daubois
Copy link
Contributor

@alexandre-daubois alexandre-daubois commented Apr 12, 2024 •
edited

In order to make this one pass 馃檪

@alexandre-daubois alexandre-daubois requested a review from a team as a code owner April 12, 2024 08:37
Jean85
Jean85 requested changes Apr 12, 2024
View reviewed changes
Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 馃憤

Let's wait for @shadowhand review and call for a vote

dbu
dbu approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess i am not allowed to vote, but I support the change.

I had previously verified that there is no complaint from PHP when the extending class does not yet have the ? in its parameter type: https://3v4l.org/5TInO

@alexandre-daubois
Copy link
Contributor Author

Thank you for checking this David!

@Jean85
Copy link
Member

Jean85 commented Apr 12, 2024

@shadowhand we need you to call a vote to approve this, but before we need to fix php-fig/http-factory#16 by bumping to PHP 7.1+. Let me know how you want to proceed.

@alexandre-daubois
Copy link
Contributor Author

I'm fine providing the updated PR if the author of the current one is not able to, cc @Ayesh 馃檪

@alexandre-daubois alexandre-daubois mentioned this pull request Apr 15, 2024
Merged
@alexandre-daubois
Copy link
Contributor Author

I opened a PR to update the interface, its PHPDoc and bump minimal PHP version. If in the meantime the original author wants to update his PR, I'm totally OK to keep his 馃檪

@shadowhand
Copy link
Contributor

@shadowhand we need you to call a vote to approve this.

The vote has been called.

@mbniebergall mbniebergall requested a review from Jean85 May 9, 2024 12:40
mbniebergall
mbniebergall approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@mbniebergall mbniebergall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed voting

@Jean85 Jean85 merged commit 8639a87 into php-fig:master May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadowhand shadowhand shadowhand approved these changes

@samdark samdark samdark approved these changes

@dbu dbu dbu approved these changes

@mbniebergall mbniebergall mbniebergall approved these changes

@Jean85 Jean85 Jean85 approved these changes

Assignees

@shadowhand shadowhand

Labels
PSR-17: HTTP Factory WIP
Projects
None yet
Milestone
No milestone
6 participants
@alexandre-daubois @Jean85 @shadowhand @samdark @dbu @mbniebergall