Fixing some orthographical mistakes in PSR-1 and PSR-2 papers. #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've made some changen in the PSR-2 file. |
ghost
changed the title
| - There MUST be one space after the control structure keyword | ||
| - There MUST NOT be a space after the opening parenthesis | ||
| - There MUST NOT be a space before the closing parenthesis | ||
| - There MUST be one space after the control structure keyword. |
There was a problem hiding this comment.
all these fullstops are wrong
|
Fixed. ✌️ 😅 |
|
I'm not really sure I see a huge amount of benefit to these changes and as the spec is finalised, unless there is a good reason to change it, I'd rather leave it as-is. |
|
Okay. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes I would like to apply to this document.