Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the param of groupHug should be from type Huggable[] #849

Merged
merged 1 commit into from Feb 4, 2019
Merged

the param of groupHug should be from type Huggable[] #849

merged 1 commit into from Feb 4, 2019

Conversation

tflori
Copy link
Contributor

@tflori tflori commented Nov 28, 2016

It is not hard failure in annotation but it allows type hints

@michaelcullum
Copy link
Member

@php-fig/psr-8

@TomasVotruba
Copy link
Contributor

👍

@pullapprove pullapprove bot requested a review from mbabker November 13, 2018 12:27
drupol
drupol approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed as well.

@iansltx iansltx merged commit 8c43475 into php-fig:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@drupol drupol drupol approved these changes

@iansltx iansltx iansltx approved these changes

@mbabker mbabker Awaiting requested review from mbabker

@Jean85 Jean85 Awaiting requested review from Jean85

@michaelcullum michaelcullum Awaiting requested review from michaelcullum

@mstaples mstaples Awaiting requested review from mstaples

Assignees
No one assigned
Labels
PSR-8: Huggable
Projects
None yet
Milestone
No milestone
6 participants
@tflori @michaelcullum @TomasVotruba @samdark @drupol @iansltx