Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate hhvm build failure #14

Closed
dbu opened this issue Jan 5, 2016 · 3 comments · Fixed by #53
Closed

investigate hhvm build failure #14

dbu opened this issue Jan 5, 2016 · 3 comments · Fixed by #53

Comments

@dbu
Copy link
Collaborator

dbu commented Jan 5, 2016

investigate why hhvm builds fail and fix them. we started ignoring the fail in #11
@dbu dbu mentioned this issue Jan 5, 2016
Merged
@xabbuh
Copy link
Member

xabbuh commented Jan 5, 2016

Looks like failures are triggered by Puli.

@sagikazarmark
Copy link
Member

Confirmed, puli does not support HHVM ATM: https://github.com/puli/cli/blob/master/.travis.yml#L22

@Nyholm Nyholm mentioned this issue Feb 28, 2016
Closed
@Nyholm
Copy link
Member

Nyholm commented Feb 28, 2016

Puli is no longer a dependency to this bundle. We should consider rewrite our tests so they are not dependent of Puli.

@Nyholm Nyholm mentioned this issue Feb 28, 2016
Merged
@dbu dbu closed this as completed in #53 Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure travis can run on HHVM php-http/HttplugBundle
4 participants
@dbu @sagikazarmark @Nyholm @xabbuh