Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise logic is broken #59

Open
nicolas-grekas opened this issue Oct 3, 2019 · 0 comments

Comments

@nicolas-grekas
Copy link

commented Oct 3, 2019

  • the return value of rejection callback should reinject to fulfill the promise and recover from the error - this is not supported
  • chaining promises/callbacks is wrong, see https://blog.domenic.me/youre-missing-the-point-of-promises/
  • return from a promise can be a promise too, in which case it should we unwrapped - detailed in #32 already

I'd recommend relying on guzzle/promise to fix all these issues as the implementation there is correct.
See also https://promisesaplus.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.