Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mb_strlen & friends error section for $encoding #2751

Open
nielsdos opened this issue Sep 7, 2023 · 3 comments
Open

mb_strlen & friends error section for $encoding #2751

nielsdos opened this issue Sep 7, 2023 · 3 comments

Comments

@nielsdos
Copy link
Member

nielsdos commented Sep 7, 2023

https://www.php.net/manual/en/function.mb-strlen.php mentions in the error section that a warning may be raised with an invalid encoding. But that's not what happens: https://3v4l.org/E9s0i. A ValueError is raised instead.
For some other pages, the error condition for $encoding is also not specified. I only had a quick look instead of composing a list of all the pages that lack one.

@Girgias
Copy link
Member

Girgias commented Sep 8, 2023

The ValueError is likely raised only as of PHP 8.0, and a warning was emitted during 7.X

@nielsdos
Copy link
Member Author

nielsdos commented Sep 8, 2023

Yep just checked, that's right. So we need a changelog entry as well, both the changelog and the ValueError message would be nice as entities I guess.

@Girgias
Copy link
Member

Girgias commented Sep 8, 2023

Yup, a lot of changelog entries are already entities :D for the ValueError it would be better to just have the paragraph be an entity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants