ReflectionClass::getStaticProperties doesn't need null return type

[othercorey]

Description

The following code:

<?php
$r = new ReflectionMethod('ReflectionClass::getStaticProperties');
echo (string)$r->getTentativeReturnType();

Resulted in this output:

?array

But I expected this output instead:

array

Looks like the return paths were changed to RETURN_THROWS() in 8664ff7 and 8176059 but the stub wasn't updated.

Usually, after these cleanups, the stub is correct but the docs are outdated, however this seems to be the wrong stub.

I'm not sure how to update the stub and generated code from it.

PHP Version

8.1.14

Operating System

No response

[nielsdos]

I'm not sure how to update the stub and generated code from it.

You can edit the stub file ext/reflection/php_reflection.stub.php. After you edited it you should run make (*) and it will automatically update the generated files for you. Upon creating a PR include both the generated files and the stub file.

(*) Assuming you already ran ./buildconf and ./configure.

[Girgias]

I'm not sure how to update the stub and generated code from it.

You can edit the stub file ext/reflection/php_reflection.stub.php. After you edited it you should run make (*) and it will automatically update the generated files for you. Upon creating a PR include both the generated files and the stub file.

(*) Assuming you already ran ./buildconf and ./configure.

No need to run make, just runing ./build/gen_stubs.php should do the trick.

[othercorey]

I could be wrong, but looks like ReflectionFunctionAbstract::getClosureScopeClass() and getClosureThis() no longer return null also.

This issue was assigned to someone, so I'm not working on a PR.

[kocsismate]

Thanks for the report! Your initial claim is true, ReflectionClass:getStaticProperties indeed cannot return true, so I'll fix the return type in master.

However, ReflectionFunctionAbstract::getClosureScopeClass() can return null, there is even a test for this in php-src. A short excerpt: https://3v4l.org/hV7MZ#v8.2.1 The same is true for getClosureThis .