Skip to content

Fix GH-10259 ReflectionClass::getStaticProperties doesn't need null return type #10418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2023
Merged

Fix GH-10259 ReflectionClass::getStaticProperties doesn't need null return type #10418

merged 1 commit into from
Jan 24, 2023

Conversation

kocsismate
Copy link
Member

No description provided.

@kocsismate kocsismate linked an issue Jan 22, 2023 that may be closed by this pull request
ReflectionClass::getStaticProperties doesn't need null return type #10259
Closed
@kocsismate kocsismate requested a review from Girgias January 24, 2023 19:01
@kocsismate
Copy link
Member Author

cc @nielsdos

@kocsismate kocsismate requested a review from cmb69 January 24, 2023 19:02
@nielsdos
Copy link
Member

This looks right to me, thanks.

cmb69
cmb69 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kocsismate kocsismate merged commit 0161608 into php:master Jan 24, 2023
@kocsismate kocsismate deleted the GH-10259-return branch January 24, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

@Girgias Girgias Awaiting requested review from Girgias

Assignees
No one assigned
Labels
Extension: reflection Stubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReflectionClass::getStaticProperties doesn't need null return type
3 participants
@kocsismate @nielsdos @cmb69