Support neighbouring extension in the ZendMM custom handlers hook in zend_test
#12792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realFlowControl
referenced
this pull request
Nov 27, 2023
realFlowControl
force-pushed
the
fix-asan-for-zendmm-zend-test
branch
from
dd9c57c
to
8eab44f
Compare
realFlowControl
force-pushed
the
fix-asan-for-zendmm-zend-test
branch
from
8eab44f
to
6d67096
Compare
realFlowControl
force-pushed
the
fix-asan-for-zendmm-zend-test
branch
from
6d67096
to
4838205
Compare
github-actions
bot
added
Category: Build System
Category: Engine
Extension: intl
Extension: bcmath
Extension: bz2
Extension: calendar
Extension: com_dotnet
Extension: curl
Extension: date
Extension: dba
Extension: dom
Extension: enchant
Extension: exif
Extension: ffi
Extension: fileinfo
Extension: filter
Extension: ftp
Extension: gd
Extension: gettext
Extension: gmp
Extension: hash
and removed
Extension: zend_test
labels
github-actions
bot
added
Extension: zend_test
and removed
Extension: curl
Extension: date
Extension: dba
Extension: dom
Extension: enchant
Extension: exif
Extension: ffi
Extension: fileinfo
Extension: filter
Extension: ftp
Extension: gd
Extension: gettext
Extension: gmp
Extension: hash
Extension: iconv
Extension: imap
Extension: json
Extension: ldap
Extension: libxml
Extension: mbstring
Extension: mysqli
Extension: mysqlnd
Extension: oci8
Category: Optimizer
labels
|
@bwoebi can I ping you to review this PR? |
bwoebi
reviewed
Feb 15, 2024
Comment on lines
+527
to
+530
| int flag = 0; | ||
| memcpy(&flag, heap, sizeof(int)); | ||
| int new_flag = 0; | ||
| memcpy(heap, &new_flag, sizeof(int)); |
There was a problem hiding this comment.
Yeah, no.
It works, but we should not do it this way, especially not advertise that in php-src itself.
You probably should include a
#ifndef ZEND_ALLOC_HIDE_STRUCTS
struct _zend_mm_heap {
#if ZEND_MM_CUSTOM
int use_custom_mm_heap;
#endif
}
#endif
to zend_alloc.h, with #define ZEND_ALLOC_HIDE_STRUCTS 1 in zend_alloc.c
and have it public API.
If we rely on such implementation details, it can well just be public.
There was a problem hiding this comment.
Hmm, I get the point and the zend_test_prepare_zendmm_for_call() is super ugly 😉
OTOH I would rather not make the use_custom_mm_heap flag public just for the sake of this test.
I am about to prepare a PR that would add a gc and shutdown custom handler (#13432) that might help solve this.
|
Closing this in favour of #13432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for neighouring extensions in the
zend_mm_set_custom_handlers()hook, asUSE_ZEND_ALLOC=0technically installs a custom memory handler in the ZendMM and is used for the ASAN tests.This realtes to #12768 and #12758
As the PHP 8.1 merge window has closed, this targets PHP 8.2