Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double dotted line in sidebar #190

Merged
merged 2 commits into from Mar 14, 2018
Merged

Conversation

hannesvdvreken
Copy link
Contributor

@lex111
Copy link
Member

lex111 commented Dec 1, 2017

It's a bit not what I had in mind. I pointed out that need to remove short borders, i.e. long borders should only be displays.

After apply patch Expected
image image

But maybe it's better, I don't know, just leaving only the short borders, it doesn't look very good:

image

@hannesvdvreken
Copy link
Contributor Author

hannesvdvreken commented Dec 1, 2017

so: the links in a list should have short lines,
the lines under titles, and links that aren't in a list: long lines.

right?

@lex111
Copy link
Member

lex111 commented Dec 1, 2017

@hannesvdvreken I think so.

@salathe
Copy link
Contributor

salathe commented Dec 1, 2017

Something like the following looks better, to me. The border-bottom: none line should be all that is really required to remove the extra border.

diff --git a/styles/theme-medium.css b/styles/theme-medium.css
index affadcef..8a0437b2 100755
--- a/styles/theme-medium.css
+++ b/styles/theme-medium.css
@@ -410,6 +410,9 @@ aside.tips a {
   color:#ccc;
   border-bottom:1px dotted #666;
 }
+aside.tips .panel > a {
+  border-bottom: none;
+}
 aside.tips .panel > a:after,
 aside.tips .panel > span:after {
   content:" ";

I'd also be temped to thrown in a display: block there as well, which is a helpful usability tweak to make the anchor fill the width and so be easier to click.

@lex111
Copy link
Member

lex111 commented Dec 1, 2017

@salathe agree, I tested these styles before when I did the screenshots above.

I'd also be temped to thrown in a display: block there as well, which is a helpful usability tweak to make the anchor fill the width and so be easier to click.

It would be good 👍

@hannesvdvreken
Copy link
Contributor Author

@salathe @lex111 like this?

@lex111
Copy link
Member

lex111 commented Dec 1, 2017

@hannesvdvreken yes exactly 👍

@salathe
Copy link
Contributor

salathe commented Dec 1, 2017

@hannesvdvreken yes, that looks good to me. 👍

@php-pulls php-pulls merged commit efbf40a into php:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants