Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language/usage.rst needs update for 3.2 #21

Closed
nickvergessen opened this issue May 28, 2015 · 4 comments
Closed

language/usage.rst needs update for 3.2 #21

nickvergessen opened this issue May 28, 2015 · 4 comments
Assignees
Milestone

Comments

@nickvergessen
Copy link
Contributor

The logic was moved to phpbb\language\language instead of phpbb\user

@MateBartus did anything else change? https://github.com/phpbb/documentation/pull/20/files#diff-095e33362bf3f1179099f1e83357dfde

@nickvergessen nickvergessen added this to the 3.2.0 milestone May 28, 2015
@CHItA
Copy link
Member

CHItA commented May 28, 2015

Actually nothing should have changed, the add_lang() logic is a bit different, but if someone uses the user class then it should not matter anyway (in the rst it is in this way).

@Nicofuma
Copy link
Member

For 3.2:

  • twig lang() function: {{ lang('my_key') }}
  • language service
  • BC with /phpbb/user

@CHItA
Copy link
Member

CHItA commented May 29, 2015

I'm not sure if it should go into the doc is the change of the user::lang member var. The way core files used it in some places to check whether the user object is inited, was to use if (empty($user->lang)) which is no longer works, and user::is_setup() method should be used instead. IMO this is only relevant if there is any possibility that extensions using something like this.

@nickvergessen nickvergessen self-assigned this May 31, 2015
@iMattPro
Copy link
Member

iMattPro commented Jun 7, 2016

Handled by #38

@iMattPro iMattPro closed this as completed Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants