Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/11465] Use extension finder when adding extensions' acp modules #1313

Merged
merged 12 commits into from
May 12, 2013

Commits on Mar 21, 2013

  1. [ticket/11465] Use extension finder when adding extensions' acp modules

    The method acp_modules::get_module_infos() needs to use the extension
    finder whenever it is looking for a module's info file. While
    transitioning to the new extension system, only the initial search for all
    module info files was changed to the new system. Due to this it is not
    possible to add an extension's acp/mcp/ucp module manually in the ACP.
    This patch will always use the extension finder for the acp module's info
    files and therefore properly find the needed file. Additionally, the code
    has been cleaned up a little bit.
    
    PHPBB3-11465
    marc1706 committed Mar 21, 2013
    Configuration menu
    Copy the full SHA
    aefca4b View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2013

  1. [ticket/11465] Add unit tests for acp_modules::get_module_infos()

    The tests add 3 different modules. One acp module that should be found
    (acp/a_module), one acp module that should not be found (acp/fail_module),
    and one mcp module that should work again (mcp/a_module). The modules'
    info files had to be included as they were not auto-loaded for some
    reason.
    There are several test stages. First of, it is tested if the correct mcp
    and acp module is returned. Afterwards, the proper loading of specified
    modules is tested. One with an existing module and one with a not existing
    module. Finally, the test concludes with trying to get the module info of
    not existing ucp modules. Other classes like foobar would have also worked
    for that check but I decided to use the ucp type of class as that is the
    one type missing from the added test modules.
    
    PHPBB3-11465
    marc1706 committed Mar 22, 2013
    Configuration menu
    Copy the full SHA
    fadcee7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    11477a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2013

  1. [ticket/11465] Add phpBB module to test

    PHPBB3-11465
    nickvergessen committed Apr 10, 2013
    Configuration menu
    Copy the full SHA
    6110380 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    78bcc31 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bc423f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2013

  1. Configuration menu
    Copy the full SHA
    7240759 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2013

  1. [ticket/11465] Add comments explaining the tests

    PHPBB3-11465
    marc1706 committed May 10, 2013
    Configuration menu
    Copy the full SHA
    6a1fa3e View commit details
    Browse the repository at this point in the history

Commits on May 12, 2013

  1. [ticket/11465] Add tests for optional arguments of get_module_infos()

    The possibilities of the first argument have already been covered
    previously. The second argument will be covered with an entry that
    should exist, an incorrect entry, and the default false entry that
    should use the previously set module class. Unfortunately, the third
    argument doesn't have an effect in the tests, as the mocked extension
    manager will not properly handle enabled/disabled extensions.
    
    PHPBB3-11465
    marc1706 committed May 12, 2013
    Configuration menu
    Copy the full SHA
    7327f93 View commit details
    Browse the repository at this point in the history
  2. [ticket/11465] Add disabled ext to allow proper testing of get_module…

    …_infos()
    
    This will now also enable us to test the $use_all_available parameter of
    get_module_infos(), which will not only return the module infos for enabled
    extensions but also those from disabled extensions.
    
    PHPBB3-11465
    marc1706 committed May 12, 2013
    Configuration menu
    Copy the full SHA
    f90ed6c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7e70eec View commit details
    Browse the repository at this point in the history
  4. [ticket/11465] Increase count of disabled extensions to 5 in function…

    …al test
    
    The ACP function test checks the amount of disabled extensions. Due to
    the added disabled extension for the tests of the acp_modules method
    get_module_infos(), this needed to be increased from 4 to 5.
    
    PHPBB3-11465
    marc1706 committed May 12, 2013
    Configuration menu
    Copy the full SHA
    bd6cebf View commit details
    Browse the repository at this point in the history