[ticket/11798] Fix RealPlayer attachments #1664
Conversation
Remove controls and invalid JavaScript that do not work PHPBB3-11798
| <param name="prefetch" value="false" /> | ||
| <embed name="rmstream_{_file.ATTACH_ID}" type="audio/x-pn-realaudio-plugin" src="{_file.U_DOWNLOAD_LINK}" width="0" height="0" autostart="false" controls="ImageWindow" console="ctrls_{_file.ATTACH_ID}" prefetch="false"></embed> | ||
| <embed name="rmstream_{_file.ATTACH_ID}" type="audio/x-pn-realaudio-plugin" src="{_file.U_DOWNLOAD_LINK}" width="200" height="50" autostart="false" controls="ImageWindow" prefetch="false"></embed> |
There was a problem hiding this comment.
Why is this now width200/height50? Is this automatically corrected?
There was a problem hiding this comment.
Those are default values from official RealPlayer documentation.
|
Someone who managed to make RealPlayer work in browser should double check this PR. From 3 computers I've managed to get it working only on 1 and only in one browser, the rest of them showed error messages in RealPlayer plugin (errors related to plugin, not HTML code). Or maybe remove RealPlayer code completely? I don't think anyone uses that adware buggy crap anymore. Latest version of plugin is to ancient that it doesn't even work with new browsers. |
|
Removing it may be the way to go for develop, should keep it still for olympus if it does work at all. |
|
@cyberalien what do you think? |
|
Sounds good |
|
I'm all in favour of just removing this in develop. |
|
Me too. Including QuickTime and Windows Media. |
|
Lets close this and make a different ticket to remove all that outdated media? |
|
@cyberalien Do you think this patch should go into develop-olympus? The code you are removing is only executed in case of |
|
@bantu yes, I think so too |
|
Closing as such. |
|
A ticket was never created @cyberalien |
Remove controls and invalid JavaScript that do not work
http://tracker.phpbb.com/browse/PHPBB3-11798