[ticket/11098] Add mark/unmark all options to remember me keys #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <!-- IF .errors --> | ||
| <p class="error"> | ||
| <!-- BEGIN errors --> | ||
| {errors} <br /> |
There was a problem hiding this comment.
This is most likly wrong. should be {errors.SOMETHING}
There was a problem hiding this comment.
well why did they make it like that then 👎
There was a problem hiding this comment.
Actually that appears to be the way it is handled (or wrong)??:
https://github.com/phpbb/phpbb/blob/develop/phpBB/includes/ucp/ucp_profile.php#L682
There was a problem hiding this comment.
while ($row = $db->sql_fetchrow($result))
{
$template->assign_block_vars('sessions', array(
'errors' => $error,
Can you fix it in the ucp_profile.php?
|
Fixed incorrect error reporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.phpbb.com/browse/PHPBB3-11098
This also involved a bit of cleanup for consistency and valid markup.
While at it, made a tiny HTML valid markup fix to the notifications
page as well.