[ticket/10899] Using Delete All in log viewer with keyword search #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per IRC the log class should perform the deleting |
PHPBB3-10899
PHPBB3-10899
|
Code looks good, but tests for |
| @@ -26,7 +26,7 @@ function main($id, $mode) | |||
| { | |||
| global $db, $user, $auth, $template, $cache, $phpbb_container; | |||
| global $config, $phpbb_root_path, $phpbb_admin_path, $phpEx; | |||
| global $request; | |||
| global $request, $phpbb_log; | |||
I agree |
PHPBB3-10899
| } | ||
|
|
||
| $sql = 'DELETE FROM ' . LOG_TABLE . " | ||
| $sql_where"; |
There was a problem hiding this comment.
tabs are off?
It should be "the same as before $sql" + 1
PHPBB3-10899
PHPBB3-10899
PHPBB3-10899
| $log_type = false; | ||
| } | ||
|
|
||
| if ($log_type === false) |
There was a problem hiding this comment.
Add an event for extensions before this?
There was a problem hiding this comment.
core.log_delete_before?
There was a problem hiding this comment.
yes, but see core.add_log and add a similar NOTE about the log_type
PHPBB3-10899
PHPBB3-10899
| * NOTE: if sql_ary does not contain a log_type value, the entry will | ||
| * not be deleted in the database. So ensure to set it, if needed. | ||
| * | ||
| * @event core.add_log |
PHPBB3-10899
nickvergessen
added a commit
that referenced
this pull request
May 30, 2014
[ticket/10899] Using Delete All in log viewer with keyword search * Nicofuma/ticket/10899: [ticket/10899] Update doc block [ticket/10899] Use isset($field_value['IN']) [ticket/10899] Add event core.delete_log [ticket/10899] Remove trailing ; [ticket/10899] Fix typo in the class name [ticket/10899] Add unit tests [ticket/10899] Get $phpbb_log from the container [ticket/10899] Remove extra ';' [ticket/10899] Typo [ticket/10899] Refactoring in \phpbb\log\log_interface [ticket/10899] Using Delete All in log viewer with keyword search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.phpbb.com/browse/PHPBB3-10899
PHPBB3-10899