New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12559] Add forum setting to limit subforums legend to direct children only #2473

Closed
wants to merge 1,065 commits into
base: develop-ascraeus
from

Conversation

Projects
None yet
@Nicofuma

This comment has been minimized.

Show comment
Hide comment
@Nicofuma

Nicofuma May 17, 2014

Member

you should update https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/install/schemas/schema.json too and then run develop/create_schema_files.php

Member

Nicofuma commented May 17, 2014

you should update https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/install/schemas/schema.json too and then run develop/create_schema_files.php

@bantu

This comment has been minimized.

Show comment
Hide comment
@bantu

bantu May 17, 2014

Member

@Nicofuma schema.json is automatically generated from the migrations. This is what develop/create_schema_files.php does (I think).

Member

bantu commented May 17, 2014

@Nicofuma schema.json is automatically generated from the migrations. This is what develop/create_schema_files.php does (I think).

@Nicofuma

This comment has been minimized.

Show comment
Hide comment
@Nicofuma

Nicofuma May 17, 2014

Member

right, so he only has to run develop/create_schema_files.php

Member

Nicofuma commented May 17, 2014

right, so he only has to run develop/create_schema_files.php

@PayBas

This comment has been minimized.

Show comment
Hide comment
@PayBas

PayBas May 17, 2014

Contributor

Yeah I forgot to run the script ;), thanks.

Contributor

PayBas commented May 17, 2014

Yeah I forgot to run the script ;), thanks.

return array(
'add_columns' => array(
$this->table_prefix . 'forums' => array(
'display_subforum_limit' => array('BOOL', 0, 'after' => 'display_subforum_list'),

This comment has been minimized.

@nickvergessen

nickvergessen May 18, 2014

Contributor

We didn't use after since now, as not all DBMS support it

@nickvergessen

nickvergessen May 18, 2014

Contributor

We didn't use after since now, as not all DBMS support it

This comment has been minimized.

@PayBas

PayBas May 18, 2014

Contributor

So just remove it?

@PayBas

PayBas May 18, 2014

Contributor

So just remove it?

This comment has been minimized.

@nickvergessen

nickvergessen May 18, 2014

Contributor

Well I guess it's fine but can you add a ticket that the schema generator should process after instead of adding it to the .json file? That would be awesome

@nickvergessen

nickvergessen May 18, 2014

Contributor

Well I guess it's fine but can you add a ticket that the schema generator should process after instead of adding it to the .json file? That would be awesome

This comment has been minimized.

@PayBas
@PayBas

PayBas May 18, 2014

Contributor
Show outdated Hide outdated phpBB/install/schemas/schema.json Outdated
Show outdated Hide outdated phpBB/includes/functions_display.php Outdated
@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen May 28, 2014

Contributor

#2474 has been merged, please rebase

Contributor

nickvergessen commented May 28, 2014

#2474 has been merged, please rebase

@PayBas

This comment has been minimized.

Show comment
Hide comment
@PayBas

PayBas Aug 21, 2014

Contributor

It appears that this doesn't work for categories. So I'll have to improve this before merge.

Contributor

PayBas commented Aug 21, 2014

It appears that this doesn't work for categories. So I'll have to improve this before merge.

@phpbb-user phpbb-user added the WIP label Aug 21, 2014

@PayBas

This comment has been minimized.

Show comment
Hide comment
@PayBas

PayBas Aug 21, 2014

Contributor

Actually, adding this as an option for categories in the ACP module is very tricky. There isn't really any place for a unique setting that is shared by forums & categories, but not links. We can't simply duplicate form components for obvious reasons, and introducing yet another table column for categories which does exactly the same thing as the forum version... that's just silly.

So I'm going to leave it as is. If admins really want to limit subforums for categories, they can change the forum type to "forum", change the setting, and change the type back to "category".

Not ideal, but it's the cleanest way, code-wise.

Contributor

PayBas commented Aug 21, 2014

Actually, adding this as an option for categories in the ACP module is very tricky. There isn't really any place for a unique setting that is shared by forums & categories, but not links. We can't simply duplicate form components for obvious reasons, and introducing yet another table column for categories which does exactly the same thing as the forum version... that's just silly.

So I'm going to leave it as is. If admins really want to limit subforums for categories, they can change the forum type to "forum", change the setting, and change the type back to "category".

Not ideal, but it's the cleanest way, code-wise.

@phpbb-user phpbb-user removed the WIP label Aug 21, 2014

@Nicofuma

This comment has been minimized.

Show comment
Hide comment
@Nicofuma
Member

Nicofuma commented Sep 14, 2014

@nickvergessen thought?

@nickvergessen nickvergessen modified the milestone: 3.2.0 Oct 22, 2014

marc1706 and others added some commits Nov 18, 2014

Merge branch 'develop-ascraeus' into develop
* develop-ascraeus:
  [ticket/13315] Check for the includes/captcha/plugins/ directory instead.
  [ticket/13315] Fix loss of CAPTCHA plugin config value.
Merge branch 'develop-ascraeus' into develop
* develop-ascraeus:
  [ticket/13342] Fix invalid resetting of CAPTCHA plugin when using Recaptcha.
Merge pull request #2957 from Nicofuma/ticket/13063
[ticket/13063] Introduces a new \phpbb\routing\router class

Nicofuma and others added some commits Oct 8, 2014

Merge pull request #3028 from Nicofuma/ticket/13139
[ticket/13139] Update Twig to 1.18.0

* Nicofuma/ticket/13139:
  [ticket/13139] Fix tests
  [ticket/13139] Update Twig to 1.8.0
  [ticket/13139] Update Twig to 1.16.2
Merge branch 'develop-ascraeus' into develop
* develop-ascraeus:
  [ticket/13569] Add missing sql_freeresults and remove unneeded results
Merge branch 'develop-ascraeus' into develop
* develop-ascraeus:
  [ticket/13538] Add tests for double nested pagination loop
  [ticket/13538] Fix tests for pagination in nested loop
  [ticket/13538] Add test for pagination in nested loop
Merge pull request #3281 from MGaetan89/ticket/13496
[ticket/13496] Change set_config_count() calls with $config->increment()

* MGaetan89/ticket/13496:
  [ticket/13496] Update calls to `set_config_count()`
Merge branch 'develop-ascraeus' into develop
* develop-ascraeus:
  [ticket/13348] Remove unnecessary global $cache
  [ticket/13348] Use close method to free query result handle
Merge pull request #3257 from MGaetan89/ticket/13455
[ticket/13455] Change request_var() calls with $request->variable()

* MGaetan89/ticket/13455:
  [ticket/13455] Remove `request_var()` references from comments
  [ticket/13455] Remove unnecessary calls to `utf8_normalize_nfc()`
  [ticket/13455] Update calls to `request_var()`
Merge pull request #3207 from Nicofuma/ticket/13407
[ticket/13407] Update Symfony to 2.7.*@dev

* Nicofuma/ticket/13407:
  [ticket/13407] Update composer.lock file
  [ticket/13407] Bump minimal version to php 5.3.9
  [ticket/13407] Introduce a request_stack service
  [ticket/13407] Remove the last occurence of pattern in routing files
  [ticket/13407] Update Symfony to 2.7.*@dev
@Nicofuma

This comment has been minimized.

Show comment
Hide comment
@Nicofuma

Nicofuma Feb 5, 2015

Member

please rebase onto develop and replace your request_var() calls by $request->variable()

Member

Nicofuma commented Feb 5, 2015

please rebase onto develop and replace your request_var() calls by $request->variable()

@PayBas

This comment has been minimized.

Show comment
Hide comment
@PayBas

PayBas Feb 9, 2015

Contributor

Replaced by #3386

Contributor

PayBas commented Feb 9, 2015

Replaced by #3386

@PayBas PayBas closed this Feb 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment