[ticket/12559] Add forum setting to limit subforums legend to direct children only #2473
Conversation
|
you should update https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/install/schemas/schema.json too and then run develop/create_schema_files.php |
|
@Nicofuma schema.json is automatically generated from the migrations. This is what develop/create_schema_files.php does (I think). |
|
right, so he only has to run develop/create_schema_files.php |
|
Yeah I forgot to run the script ;), thanks. |
| return array( | ||
| 'add_columns' => array( | ||
| $this->table_prefix . 'forums' => array( | ||
| 'display_subforum_limit' => array('BOOL', 0, 'after' => 'display_subforum_list'), |
There was a problem hiding this comment.
We didn't use after since now, as not all DBMS support it
There was a problem hiding this comment.
Well I guess it's fine but can you add a ticket that the schema generator should process after instead of adding it to the .json file? That would be awesome
There was a problem hiding this comment.
|
#2474 has been merged, please rebase |
|
It appears that this doesn't work for categories. So I'll have to improve this before merge. |
|
Actually, adding this as an option for categories in the ACP module is very tricky. There isn't really any place for a unique setting that is shared by forums & categories, but not links. We can't simply duplicate form components for obvious reasons, and introducing yet another table column for categories which does exactly the same thing as the forum version... that's just silly. So I'm going to leave it as is. If admins really want to limit subforums for categories, they can change the forum type to "forum", change the setting, and change the type back to "category". Not ideal, but it's the cleanest way, code-wise. |
|
@nickvergessen thought? |
naderman
force-pushed
the
develop-ascraeus
branch
from
61ad400
to
0e772af
Compare
* develop-ascraeus: [ticket/13315] Check for the includes/captcha/plugins/ directory instead. [ticket/13315] Fix loss of CAPTCHA plugin config value.
* develop-ascraeus: [ticket/13342] Fix invalid resetting of CAPTCHA plugin when using Recaptcha.
PHPBB3-13063
PHPBB3-13063
PHPBB3-13139
[ticket/13139] Update Twig to 1.18.0 * Nicofuma/ticket/13139: [ticket/13139] Fix tests [ticket/13139] Update Twig to 1.8.0 [ticket/13139] Update Twig to 1.16.2
* develop-ascraeus: [ticket/13569] Add missing sql_freeresults and remove unneeded results
* develop-ascraeus: [ticket/13538] Add tests for double nested pagination loop [ticket/13538] Fix tests for pagination in nested loop [ticket/13538] Add test for pagination in nested loop
[ticket/13496] Change set_config_count() calls with $config->increment() * MGaetan89/ticket/13496: [ticket/13496] Update calls to `set_config_count()`
* develop-ascraeus: [ticket/13348] Remove unnecessary global $cache [ticket/13348] Use close method to free query result handle
PHPBB3-13455
PHPBB3-13407
PHPBB3-13407
PHPBB3-13407
PHPBB3-13407
[ticket/13455] Change request_var() calls with $request->variable() * MGaetan89/ticket/13455: [ticket/13455] Remove `request_var()` references from comments [ticket/13455] Remove unnecessary calls to `utf8_normalize_nfc()` [ticket/13455] Update calls to `request_var()`
[ticket/13407] Update Symfony to 2.7.*@dev * Nicofuma/ticket/13407: [ticket/13407] Update composer.lock file [ticket/13407] Bump minimal version to php 5.3.9 [ticket/13407] Introduce a request_stack service [ticket/13407] Remove the last occurence of pattern in routing files [ticket/13407] Update Symfony to 2.7.*@dev
|
please rebase onto develop and replace your request_var() calls by $request->variable() |
PHPBB3-10748
[ticket/10748] Split MS SQL from the db tools file into it's own
Squashed all commits, they were basically just typos and errors PHPBB3-12559
PHPBB3-12559
|
Replaced by #3386 |
https://tracker.phpbb.com/browse/PHPBB3-12559
http://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=45585
PHPBB3-12559