[ticket/12325] Automatic update should notify about outdated files #2493
Conversation
| @@ -501,6 +503,7 @@ | |||
| 'SELECT_DOWNLOAD_FORMAT' => 'Select download archive format', | |||
| 'SELECT_FTP_SETTINGS' => 'Select FTP settings', | |||
| 'SHOW_DIFF_CONFLICT' => 'Show differences/conflicts', | |||
| 'SHOW_DIFF_DELETED' => 'Show file contents', | |||
There was a problem hiding this comment.
it's to be consistent with new files
|
It's stuck in an infinte loop for me |
PHPBB3-12325
|
fixed |
| <dl> | ||
| <dt style="width: 60%;"><strong><!-- IF deleted.DIR_PART -->{deleted.DIR_PART}<br /><!-- ENDIF -->{deleted.FILE_PART}</strong> | ||
| </dt> | ||
| <dd style="margin-{S_CONTENT_FLOW_BEGIN} 60%;"> |
There was a problem hiding this comment.
now the : is missing :P
There was a problem hiding this comment.
well, we have to use L_COLON
There was a problem hiding this comment.
No, use :
L_COLON is translatable, some language may use -- instead and then the css is broken?
PHPBB3-12325
|
Hmm I just tried to update from 3.0.12 to 3.1.0-b4 |
| <legend><img src="{T_IMAGE_PATH}icon_delete.gif" alt="{L_STATUS_DELETED}" /></legend> | ||
| <!-- BEGIN deleted --> | ||
| <dl> | ||
| <dt style="width: 60%;"><strong><!-- IF deleted.DIR_PART -->{deleted.DIR_PART}<br /><!-- ENDIF -->{deleted.FILE_PART}</strong> |
There was a problem hiding this comment.
Not really important, but everything from <strong> shoud be on a new line, no?
Or </dt> on the previous line.
PHPBB3-12325
[ticket/12325] Automatic update should notify about outdated files * Nicofuma/ticket/12325: [ticket/12325] Update coding style in template [ticket/12325] Fix: add a missing colon [ticket/12325] Don't use L_COLON [ticket/12325] Fix: it's not stuck in an inifinite loop anymore [ticket/12325] Automatic update should notify about outdated files
| @@ -514,6 +517,7 @@ | |||
| 'STAGE_UPDATE_FILES' => 'Update files', | |||
| 'STAGE_VERSION_CHECK' => 'Version check', | |||
| 'STATUS_CONFLICT' => 'Modified file producing conflicts', | |||
| 'L_STATUS_DELETED' => 'Deleted file', | |||
PHPBB3-12325
phpBB and the FTP user are usually different, so this likely won't be possibly in most cases.
The latter please. |
|
With this patch the file list is quite long, when updating from 3.0 to 3.1 |
[ticket/12325] Automatic update should notify about outdated files * Nicofuma/ticket/12325: [ticket/12325] Fix the language var name [ticket/12325] Update coding style in template [ticket/12325] Fix: add a missing colon [ticket/12325] Don't use L_COLON [ticket/12325] Fix: it's not stuck in an inifinite loop anymore [ticket/12325] Automatic update should notify about outdated files
https://tracker.phpbb.com/browse/PHPBB3-12325
PHPBB3-12325