[ticket/12563] Changes 2 style specific language variables for better understanding #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…names PHPBB3-12563
| @@ -209,8 +209,8 @@ protected function action_install() | |||
| trigger_error($this->user->lang['NO_MATCHING_STYLES_FOUND'] . adm_back_link($this->u_action), E_USER_WARNING); | |||
| } | |||
| $message = implode('<br />', $messages); | |||
| $message .= '<br /><br />' . sprintf($this->user->lang['STYLE_INSTALLED_RETURN_STYLES'], $this->u_base_action . '&mode=style'); | |||
| $message .= '<br /><br />' . sprintf($this->user->lang['STYLE_INSTALLED_RETURN_UNINSTALLED'], $this->u_base_action . '&mode=install'); | |||
| $message .= '<br /><br />' . sprintf($this->user->lang['STYLE_INSTALLED_RETURN_INSTALLED_STYLES'], $this->u_base_action . '&mode=style'); | |||
There was a problem hiding this comment.
While on it, change to $this->user->lang(
There was a problem hiding this comment.
$message .= '<br /><br />' . $this->user->lang('STYLE_INSTALLED_RETURN_INSTALLED_STYLES', $this->u_base_action . '&mode=style');
Like this?
There was a problem hiding this comment.
Yes atleast if i see it correct on my phone
There was a problem hiding this comment.
Changed it. Is working fine.
Crizz0
changed the title
Crizz0
changed the title
bantu
added a commit
to bantu/phpbb
that referenced
this pull request
Jun 13, 2014
[ticket/12563] Changes 2 style specific language variables for better understanding * Crizz0/ticket/12563: [ticket/12563] Removes strintf in acp_styles.php and shorts up <a> [ticket/12563] Changes 2 language variables to better understandable names
| @@ -71,8 +71,8 @@ | |||
| 'STYLE_ERR_NAME_EXIST' => 'A style with that name already exists.', | |||
| 'STYLE_ERR_STYLE_NAME' => 'You must supply a name for this style.', | |||
| 'STYLE_INSTALLED' => 'Style "%s" has been installed.', | |||
| 'STYLE_INSTALLED_RETURN_STYLES' => '<a href="%s">Click here</a> to return to installed styles list.', | |||
| 'STYLE_INSTALLED_RETURN_UNINSTALLED' => '<a href="%s">Click here</a> to install more styles.', | |||
| 'STYLE_INSTALLED_RETURN_INSTALLED_STYLES' => '<a href="%s">Return to installed styles list</a>.', | |||
There was a problem hiding this comment.
I don't think these are full sentences anymore, so the dots at the end should be removed. It also looks weird that the dot is not part of the link.
There was a problem hiding this comment.
This is inconsistent with other messages, e.g.
PHPBB3-12563
|
I'm trying to setup the << before the link, but it is not working: Just creates to wrong a-Elements. |
|
as per IRC conversation, remove from language and use laquo and raquo for the two options "return to installed styles" and "install more styles" respectively. |
dhruvgoel92
added a commit
that referenced
this pull request
Jun 23, 2014
[ticket/12563] Changes 2 style specific language variables for better understanding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little changes on two language variables.
PHPBB3-12563 - https://tracker.phpbb.com/browse/PHPBB3-12563