Add event to acp_main.php to notice admin #2775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like the notice on the main acp page, extensions should be able to generate their own notice for the admin. There is already a html event acp_main_notice_after so it should be able to do their own notice. http://area51.phpbb.com/phpBB/viewtopic.php?f=111&t=45987
| * @since 3.1.0-RC3 | ||
| */ | ||
| $vars = array(); | ||
| extract($phpbb_dispatcher->trigger_event('core.acp_main_notice', compact($vars))); |
There was a problem hiding this comment.
Use $phpbb_dispatcher->dispatch('core.acp_main_notice'); if there are not parameters (without the $vars = ... and without the extract())
|
Please read through https://wiki.phpbb.com/Git#Branch_Names and correct branch name and commit messages. Also if there is no existing ticket for this patch at tracker.phpbb.com/issues/ please feel free to open a new one. Thanks for the patch, it looks good to me. |
| * @event core.acp_main_notice | ||
| * @since 3.1.0-RC3 | ||
| */ | ||
| $phpbb_dispatcher->trigger_event('core.acp_main_notice'); |
There was a problem hiding this comment.
dispatch instead of trigger_event
As Joas Schilling asked
|
Merged with 64f2d77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the notice on the main acp page, extensions should be able to generate their own notice for the admin. There is already a html event acp_main_notice_after so it should be able to do their own notice.
http://area51.phpbb.com/phpBB/viewtopic.php?f=111&t=45987