[ticket/12889] Set max width to multi-select lists #2946
Conversation
|
Fine with me. Can't think of a situation where this would cause problems. |
|
should be unnecessary as width is set on container. If their is a section that this is a problem in its because we have failed to set a container width and that would need fixed. |
|
@hanakin not true in this situation. Just try it. |
|
@PayBas what situation its a global change? and it does not even fix the problem in the ticket. Not to mention that its not even possible to enter a valid email that long into phpbb as far as I am aware. This seems like a larger issue to me as it seems we are using an improper UI tool here or we need to add ... to strings over a certain length for the option |
| @@ -127,6 +127,7 @@ dd input, dd textarea { | |||
|
|
|||
| dd select { | |||
| width: auto; | |||
| max-width: 100%; | |||
There was a problem hiding this comment.
This can't be so global. As I proposed in comment at tracker, you need to limit this to [multiple] selects, since this patch makes all selectboxes stretch to full width.
There was a problem hiding this comment.
still how is this a problem as the field is limited by 100 chars
There was a problem hiding this comment.
Is this a question for me? In my opinion, pick-one select boxes should not be stretched to full width. Instead, it should adapt to width required by the longest text of the options. It makes user experience less painful and IMHO it looks better.
There was a problem hiding this comment.
agree it should be handled in that way but its not a bug preventing release as we are limiting the field to 100 to chars on entry, and their is better ways to implement this in a future release
There was a problem hiding this comment.
@josh-js please remove the max-width from this
|
@prototech your call |
|
As hanakin pointed, this doesn't address the problem. The select will pop out of the container once the window gets below a certain width. This issue does need to be addressed at least partially for 3.1 as the scrollbar is currently cut off, so it's not possible to scroll through the list. Ultimately, the whole interface needs to be redesigned because currently it's not possible to sort/search through it, making it useless once the list gets really long. But that's for 3.2. At the very least, let's go with Seny's proposal here https://tracker.phpbb.com/browse/PHPBB3-12889?focusedCommentId=54416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-54416 which is forcing the width to 100% for select[multiple]. |
|
Oh lol, apparently i tested this with a space or something in the string. So I thought this worked. Apologies for the confusion. |
| @@ -127,6 +127,7 @@ dd input, dd textarea { | |||
|
|
|||
| dd select { | |||
| width: auto; | |||
| max-width: 100%; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please add the following here dd select[multiple] { width: 100%; } as per the original ticket
|
Replaced by #2987 |
PHPBB3-12889