Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/12889] Set max width to multi-select lists #2946

Closed
wants to merge 1 commit into from
Closed

[ticket/12889] Set max width to multi-select lists #2946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions phpBB/styles/prosilver/theme/forms.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ dd input, dd textarea {

dd select {
width: auto;
max-width: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be so global. As I proposed in comment at tracker, you need to limit this to [multiple] selects, since this patch makes all selectboxes stretch to full width.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still how is this a problem as the field is limited by 100 chars

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a question for me? In my opinion, pick-one select boxes should not be stretched to full width. Instead, it should adapt to width required by the longest text of the options. It makes user experience less painful and IMHO it looks better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree it should be handled in that way but its not a bug preventing release as we are limiting the field to 100 to chars on entry, and their is better ways to implement this in a future release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josh-js please remove the max-width from this

}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the following here dd select[multiple] { width: 100%; } as per the original ticket

dd textarea {
Expand Down