[ticket/13853] Flexible schema for profilefields step 1 configuration #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds methods to enable, disable and purge profile field types to the profilefields\manager class. These methods are to be called from extensions that add new profile field types on the enable, disable and purge methods of the ext class. If not done, any profile field of a new type that is left after extension is disabled or removed will break the forum in several places. PHPBB3-13867
Adds methods to enable, disable and purge profile field types to the profilefields\manager class. These methods are to be called from extensions that add new profile field types on the enable, disable and purge methods of the ext class. If not done, any profile field of a new type that is left after extension is disabled or removed will break the forum in several places. Typo fixed. PHPBB3-13867
Modify the way adm/style/acp_profile.html STEP 1 (lines 106 to 128) is coded to make it flexible and expandable to other new types of profile fields, rather than the current mechanism, hardcoded for the default types. A flexible mechanism similar to the one used of STEP 2 is used. This required a slight modification of the type_interface, and corresponding modifications to all implementations of that interface. PHPBB3-13853
javiexin
changed the title
|
Sorry, I created my branch off of another ticket branch, but the changes are independent. |
Modify the way adm/style/acp_profile.html STEP 1 (lines 106 to 128) is coded to make it flexible and expandable to other new types of profile fields, rather than the current mechanism, hardcoded for the default types. A flexible mechanism similar to the one used of STEP 2 is used. This required a slight modification of the type_interface, and corresponding modifications to all implementations of that interface. Fixed an unrelated bug in type_interface, get_field_name was missing. PHPBB3-13853
|
Don't know why Bamboo is not working, it's been four days since my last commit, and still "in progress". |
|
Rerunning tests here. |
|
Again, Bamboo is not working |
|
It's not working because your PR is against develop-ascraeus. Please open another PR against 3.1.x. |
|
How do i do that |
|
Just close this pull request and create another one. Then, make sure you select 3.1.x from the branch dropdown (should be the default choice). |
|
Thanks |
|
3.1.x...javiexin:ticket/13853 to crate a new PR |
|
New PR open #3717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the way adm/style/acp_profile.html STEP 1 (lines 106 to 128)
is coded to make it flexible and expandable to other new types of
profile fields, rather than the current mechanism, hardcoded for
the default types.
A flexible mechanism similar to the one used of STEP 2 is used.
This required a slight modification of the type_interface, and
corresponding modifications to all implementations of that interface.
PHPBB3-13853