[ticket/13981] Add events to capture avatar deletion or overwriting #3738
Conversation
An event to capture overwriting, and another to capture deletion. Includes better error processing. PHPBB3-13981
| @@ -80,6 +80,8 @@ public function prepare_form($request, $template, $user, $row, &$error) | |||
| */ | |||
| public function process_form($request, $template, $user, $row, &$error) | |||
| { | |||
| global $phpbb_dispatcher; | |||
There was a problem hiding this comment.
The phpbb_dispatcher should be passed as a service and not be global.
An event to capture overwriting, and another to capture deletion. Includes better error processing. Replaced global by dependency injection. PHPBB3-13981
| * @param \phpbb\cache\driver\driver_interface $cache Cache driver | ||
| */ | ||
| public function __construct(\phpbb\config\config $config, $phpbb_root_path, $php_ext, \phpbb\path_helper $path_helper, \phpbb\mimetype\guesser $mimetype_guesser, \phpbb\cache\driver\driver_interface $cache = null) | ||
| public function __construct(\phpbb\config\config $config, $phpbb_root_path, $php_ext, \phpbb\path_helper $path_helper, \phpbb\mimetype\guesser $mimetype_guesser, \phpbb\cache\driver\driver_interface $dispatcher, \phpbb\cache\driver\driver_interface $cache = null) |
There was a problem hiding this comment.
The dispatcher is not \phpbb\cache\driver\driver_interface
There was a problem hiding this comment.
Oops... Copy&paste creep. Fixed.
An event to capture overwriting, and another to capture deletion. Includes better error processing. Replaced global by dependency injection. Fix typo. PHPBB3-13981
|
Are the Travis and Bamboo errors relevant, or just caused because we have changed the constructor parameters, and therefore the tests do not match the new prototype? |
|
No, you need to update the constructor(s) of the upload avatar in the tests. Travis is telling you which files you need to look in. |
|
I don't know how to do that, I have never used Travis myself. I will look into it though. |
An event to capture overwriting, and another to capture deletion. Includes better error processing. Replaced global by dependency injection. Fix Travis tests. PHPBB3-13981
|
These tests failing seem unrelated to the submitted PR |
| 'row', | ||
| 'error', | ||
| ); | ||
| extract($this->dispatcher->trigger_event('core.avatar_driver_upload_overwrite_before', compact($vars))); |
There was a problem hiding this comment.
I'd like it more if you could change the name to core.avatar_driver_upload_move_file_before. It's not always overwriting a file so calling it that is somewhat not correct.
There was a problem hiding this comment.
Ok, change is coming.
An event to capture new avatar moving in place (and maybe overwriting existing avatar), and another to capture deletion. Includes better error processing. Rename event. PHPBB3-13981
[ticket/13981] Add events to capture avatar deletion or overwriting
[ticket/13981] Add events to capture avatar deletion or overwriting
PHPBB3-13981