Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/14536] Force unix time stamps to be integer #4222

Merged
merged 1 commit into from
Mar 24, 2016

Conversation

marc1706
Copy link
Member

This will ensure to prevent PHP fatal errors in case the passed timestamp
is an empty string or does not evaluate to an integer (i.e. strings like
foobar).

Ticket: https://tracker.phpbb.com/browse/PHPBB3-14536

@marc1706 marc1706 added this to the 3.1.9 milestone Mar 14, 2016
@marc1706
Copy link
Member Author

Build error was solved by restarting tests 👍

This will ensure to prevent PHP fatal errors in case the passed timestamp
is an empty string or does not evaluate to an integer (i.e. strings like
foobar).

PHPBB3-14536
@marc1706 marc1706 changed the title [ticket/14536] Force unix time stampe to be integer [ticket/14536] Force unix time stamps to be integer Mar 23, 2016
@marc1706
Copy link
Member Author

Also see https://tracker.phpbb.com/browse/PHPBB3-13977 as a possible side effect of this PR.

@Nicofuma Nicofuma merged commit 10d4093 into phpbb:3.1.x Mar 24, 2016
Nicofuma pushed a commit that referenced this pull request Mar 24, 2016
[ticket/14536] Force unix time stamps to be integer

* marc1706/ticket/14536:
  [ticket/14536] Force unix time stamps to be integer
@marc1706 marc1706 deleted the ticket/14536 branch March 24, 2016 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants