Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/14596] Deny installation of Ascraeus under PHP 7 #4300

Closed
wants to merge 6 commits into from
Closed

[ticket/14596] Deny installation of Ascraeus under PHP 7 #4300

wants to merge 6 commits into from

Conversation

3D-I
Copy link
Contributor

@3D-I 3D-I commented Apr 21, 2016

@CHItA CHItA added this to the 3.1.10 milestone Apr 21, 2016
@3D-I
Copy link
Contributor Author

3D-I commented Apr 21, 2016

It was a PITA, but.. thanks. :)

'PHP_SETTINGS' => 'PHP version and settings',
'PHP_SETTINGS_EXPLAIN' => '<strong>Required</strong> - You must be running at least version 5.3.3 of PHP in order to install phpBB. If <var>safe mode</var> is displayed below your PHP installation is running in that mode. This will impose limitations on remote administration and similar features.',
'PHP_SETTINGS' => 'PHP versions and settings',
'PHP_SETTINGS_EXPLAIN' => '<strong>Required</strong> - You must be running at least versions 5.3.3 and less than 7 of PHP in order to install phpBB Ascraeus (3.1.x). If <var>safe mode</var> is displayed below your PHP installation is running in that mode. This will impose limitations on remote administration and similar features.',
Copy link
Member

@iMattPro iMattPro Apr 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still no good. Should be more like

you must be running at least version 5.3.3 of PHP (PHP 7 is not supported)) in order...,

And lose the ascraeus addition. It does not mean anything to end users and this change only applies to this version/branch of phpbb anyway.

@3D-I
Copy link
Contributor Author

3D-I commented Apr 22, 2016

@VSEphpbb
Ok, I will do it. Thanks.

@3D-I
Copy link
Contributor Author

3D-I commented Apr 22, 2016

Somebody please can confirm I did a right commit?
I mean, the procedure was

1 - edited again that file into my local fork
2 - committed and pushed to my remote fork

Travis automatically started then (here)

@Skouat
Copy link
Contributor

Skouat commented Apr 22, 2016

Title of the two last commits are not correct.

@3D-I
Copy link
Contributor Author

3D-I commented Apr 22, 2016

@Skouat
I aborted the first of the lasts two commits because of this, the very last commit should do though.

@Skouat
Copy link
Contributor

Skouat commented Apr 22, 2016

Nop!

The first char [ missing on the two last title ;)

@3D-I
Copy link
Contributor Author

3D-I commented Apr 22, 2016

@Skouat
Thanks. :)

@3D-I
Copy link
Contributor Author

3D-I commented Apr 22, 2016

I do not understand, maybe a travis issue?
Somebody pls can help?

https://travis-ci.org/phpbb/phpbb/jobs/125133112

@Skouat
Copy link
Contributor

Skouat commented Apr 22, 2016

It fails because two commits have a improper title.
You must undo all commits submitted april 22, and resubmit it (only one with all your changes).

@DavidIQ
Copy link
Member

DavidIQ commented Apr 22, 2016

^ what he said

@3D-I
Copy link
Contributor Author

3D-I commented Apr 22, 2016

Ok, I thought about that.

With TortoiseGit what command shoul I use then? Or git bash.
Thx.

@3D-I
Copy link
Contributor Author

3D-I commented Apr 22, 2016

I am working on it.. hopefully.
An hint shouldchelp though. :)

@3D-I
Copy link
Contributor Author

3D-I commented Apr 22, 2016

Closing in order to test something.

@3D-I 3D-I closed this Apr 22, 2016
@3D-I 3D-I deleted the patch-1 branch April 22, 2016 23:29
@iMattPro
Copy link
Member

Please make it stop 😖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants