New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ticket/14596] Deny installation of Ascraeus under PHP 7 #4300
Conversation
It was a PITA, but.. thanks. :) |
'PHP_SETTINGS' => 'PHP version and settings', | ||
'PHP_SETTINGS_EXPLAIN' => '<strong>Required</strong> - You must be running at least version 5.3.3 of PHP in order to install phpBB. If <var>safe mode</var> is displayed below your PHP installation is running in that mode. This will impose limitations on remote administration and similar features.', | ||
'PHP_SETTINGS' => 'PHP versions and settings', | ||
'PHP_SETTINGS_EXPLAIN' => '<strong>Required</strong> - You must be running at least versions 5.3.3 and less than 7 of PHP in order to install phpBB Ascraeus (3.1.x). If <var>safe mode</var> is displayed below your PHP installation is running in that mode. This will impose limitations on remote administration and similar features.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still no good. Should be more like
you must be running at least version 5.3.3 of PHP (PHP 7 is not supported)) in order...,
And lose the ascraeus addition. It does not mean anything to end users and this change only applies to this version/branch of phpbb anyway.
@VSEphpbb |
Somebody please can confirm I did a right commit? 1 - edited again that file into my local fork Travis automatically started then (here) |
Title of the two last commits are not correct. |
@Skouat |
Nop! The first char |
@Skouat |
I do not understand, maybe a travis issue? |
It fails because two commits have a improper title. |
^ what he said |
Ok, I thought about that. With TortoiseGit what command shoul I use then? Or git bash. |
I am working on it.. hopefully. |
Closing in order to test something. |
Please make it stop 😖 |
https://tracker.phpbb.com/browse/PHPBB3-14596
PHPBB3-14596