Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/14596] Deny installation of Ascraeus under PHP 7 #4300

Closed
wants to merge 6 commits into from
Closed

[ticket/14596] Deny installation of Ascraeus under PHP 7 #4300

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eb55cdf
[ticket/14596] Deny installation of Ascraeus under PHP 7
Apr 21, 2016
0ad66d5
[ticket/14596] Deny installation of Ascraeus under PHP 7
Apr 22, 2016
72f0286
ticket/14596] Deny installation of Ascraeus under PHP
Apr 22, 2016
9786b39
ticket/14596] Deny installation of Ascraeus under PHP 7
Apr 22, 2016
60c199a
[ticket/14596] Deny installation of Ascraeus under PHP 7
Apr 22, 2016
d8540fd
[ticket/14596] Deny installation of Ascraeus under PHP 7
Apr 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion phpBB/install/install_install.php
View file
Open in desktop
Expand Up @@ -154,7 +154,7 @@ function check_server_requirements($mode, $sub)
// Test the minimum PHP version
$php_version = PHP_VERSION;

if (version_compare($php_version, '5.3.3') < 0)
if ((version_compare($php_version, '5.3.3') < 0) || (version_compare($php_version, '7.0.0-dev', '>=')))
{
$result = '<strong style="color:red">' . $lang['NO'] . '</strong>';
}
Expand Down
6 changes: 3 additions & 3 deletions phpBB/language/en/install.php
View file
Open in desktop
Expand Up @@ -300,11 +300,11 @@
'PHP_REGISTER_GLOBALS' => 'PHP setting <var>register_globals</var> is disabled',
'PHP_REGISTER_GLOBALS_EXPLAIN' => 'phpBB will still run if this setting is enabled, but if possible, it is recommended that register_globals is disabled on your PHP install for security reasons.',
'PHP_SAFE_MODE' => 'Safe mode',
'PHP_SETTINGS' => 'PHP version and settings',
'PHP_SETTINGS_EXPLAIN' => '<strong>Required</strong> - You must be running at least version 5.3.3 of PHP in order to install phpBB. If <var>safe mode</var> is displayed below your PHP installation is running in that mode. This will impose limitations on remote administration and similar features.',
'PHP_SETTINGS' => 'PHP versions and settings',
'PHP_SETTINGS_EXPLAIN' => '<strong>Required</strong> - You must be running at least versions 5.3.3 and less than 7 of PHP in order to install phpBB Ascraeus (3.1.x). If <var>safe mode</var> is displayed below your PHP installation is running in that mode. This will impose limitations on remote administration and similar features.',
Copy link
Member

@iMattPro iMattPro Apr 22, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still no good. Should be more like

you must be running at least version 5.3.3 of PHP (PHP 7 is not supported)) in order...,

And lose the ascraeus addition. It does not mean anything to end users and this change only applies to this version/branch of phpbb anyway.

'PHP_URL_FOPEN_SUPPORT' => 'PHP setting <var>allow_url_fopen</var> is enabled',
'PHP_URL_FOPEN_SUPPORT_EXPLAIN' => '<strong>Optional</strong> - This setting is optional, however certain phpBB functions like off-site avatars will not work properly without it.',
'PHP_VERSION_REQD' => 'PHP version >= 5.3.3',
'PHP_VERSION_REQD' => 'PHP version >= 5.3.3, < 7',
'POST_ID' => 'Post ID',
'PREFIX_FOUND' => 'A scan of your tables has shown a valid installation using <strong>%s</strong> as table prefix.',
'PREPROCESS_STEP' => 'Executing pre-processing functions/queries',
Expand Down