New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/14823] Move check_form_key() inside actual save data step #4484

Closed
wants to merge 1 commit into
base: 3.1.x
from

Conversation

Projects
None yet
4 participants
@marc1706
Member

marc1706 commented Oct 15, 2016

Checklist:

  • Correct branch: master for new features; 3.2.x, 3.1.x for fixes
  • Tests pass
  • Code follows coding guidelines: master / 3.2.x, 3.1.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-14823

PHPBB3-14823

@Crizz0

This comment has been minimized.

Show comment
Hide comment
@Crizz0

Crizz0 Oct 15, 2016

Member

PR against master, but flag says 3.1?

Member

Crizz0 commented Oct 15, 2016

PR against master, but flag says 3.1?

@marc1706 marc1706 changed the base branch from master to 3.1.x Oct 15, 2016

@marc1706

This comment has been minimized.

Show comment
Hide comment
@marc1706

marc1706 Oct 15, 2016

Member

Better? :)

Member

marc1706 commented Oct 15, 2016

Better? :)

@Crizz0

This comment has been minimized.

Show comment
Hide comment
@Crizz0

Crizz0 Oct 15, 2016

Member

Of course 👍

Member

Crizz0 commented Oct 15, 2016

Of course 👍

@kinerity

This comment has been minimized.

Show comment
Hide comment
@kinerity

kinerity Oct 15, 2016

Contributor

Issue confirmed as fixed after applying this patch. Thanks!

Contributor

kinerity commented Oct 15, 2016

Issue confirmed as fixed after applying this patch. Thanks!

@marc1706 marc1706 closed this Oct 20, 2016

@marc1706 marc1706 reopened this Oct 20, 2016

@3D-I

This comment has been minimized.

Show comment
Hide comment
@3D-I
Contributor

3D-I commented Oct 21, 2016

@marc1706

This comment has been minimized.

Show comment
Hide comment
@marc1706

marc1706 Oct 28, 2016

Member

Closing in favor of #4489

Member

marc1706 commented Oct 28, 2016

Closing in favor of #4489

@marc1706 marc1706 closed this Oct 28, 2016

@marc1706 marc1706 deleted the marc1706:ticket/14823 branch Oct 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment