Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/14823] Move check_form_key() inside actual save data step #4484

Closed
wants to merge 1 commit into from
Closed

[ticket/14823] Move check_form_key() inside actual save data step #4484

wants to merge 1 commit into from

Conversation

marc1706
Copy link
Member

Checklist:

  • Correct branch: master for new features; 3.2.x, 3.1.x for fixes
  • Tests pass
  • Code follows coding guidelines: master / 3.2.x, 3.1.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-14823

PHPBB3-14823

@marc1706 marc1706 added this to the 3.1.11 milestone Oct 15, 2016
@Crizz0
Copy link
Member

Crizz0 commented Oct 15, 2016 •
edited
Loading

PR against master, but flag says 3.1?

@marc1706 marc1706 changed the base branch from master to 3.1.x October 15, 2016 12:52
@marc1706
Copy link
Member Author

Better? :)

@Crizz0
Copy link
Member

Crizz0 commented Oct 15, 2016

Of course 👍

@ghost
Copy link

ghost commented Oct 15, 2016

Issue confirmed as fixed after applying this patch. Thanks!

@marc1706 marc1706 closed this Oct 20, 2016
@marc1706 marc1706 reopened this Oct 20, 2016
@3D-I
Copy link
Contributor

3D-I commented Oct 21, 2016

https://www.phpbb.com/community/viewtopic.php?p=14542126#p14542126
Seems solved. What about it?

@marc1706 marc1706 mentioned this pull request Oct 27, 2016
Merged
4 tasks
@marc1706
Copy link
Member Author

Closing in favor of #4489

@marc1706 marc1706 closed this Oct 28, 2016
@marc1706 marc1706 deleted the ticket/14823 branch October 28, 2016 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.1 (Ascraeus) Blocker ⚠️
Projects
None yet
Milestone
3.1.11
3 participants
@marc1706 @Crizz0 @3D-I