[ticket/14830] Fix FORM_INVALID error during some ACP setting operations#4489
Merged
marc1706 merged 8 commits intophpbb:3.1.xfrom Oct 28, 2016
Merged
[ticket/14830] Fix FORM_INVALID error during some ACP setting operations#4489marc1706 merged 8 commits intophpbb:3.1.xfrom
marc1706 merged 8 commits intophpbb:3.1.xfrom
Conversation
rxu
changed the title
rxu
changed the title
|
The patch seems to fix the index creation, but there is a second regression compared to 3.1.9 (also FORM_INVALID) when switching the search backend via ACP from "phpBB Native Fulltext" to "MySQL Fulltext". I don't have much time to analyze what's going on, but using the 3.1.9 version of acp_search.php fixes both bugs for me. |
Contributor
Author
|
That is because the confirm box (which is triggered if the search backend is going to be changed) doesn't have the form token key. |
rxu
changed the title
rxu
changed the title
…n/deletion PHPBB3-14830
PHPBB3-14830
PHPBB3-14830
rxu
changed the title
marc1706
reviewed
Oct 27, 2016
phpBB/includes/acp/acp_profile.php
Outdated
| if (!sizeof($error)) | ||
| { | ||
| if (!check_form_key($form_key)) | ||
| if (($submit || $save) && !check_form_key($form_key)) |
Member
There was a problem hiding this comment.
Should be doing this instead:
https://github.com/phpbb/phpbb/pull/4484/files
Member
|
Looks good apart from that. You could of course also just pull in my branch from #4484 and resolve the merge conflict. |
Contributor
Author
4 tasks
marc1706
added a commit
to marc1706/phpbb
that referenced
this pull request
Oct 28, 2016
[ticket/14830] Fix FORM_INVALID error during some ACP setting operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Caused by #4452.
PHPBB3-14830.