Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ticket/14844] Replace <strong> and <em> tag with <span> and CSS in b… #4493

Closed
wants to merge 1 commit into from
Closed

[ticket/14844] Replace <strong> and <em> tag with <span> and CSS in b… #4493

wants to merge 1 commit into from

Conversation

Skouat
Copy link
Contributor

@Skouat Skouat commented Nov 1, 2016

Checklist:

  • Correct branch: master for new features; 3.2.x, 3.1.x for fixes
  • Tests pass
  • Code follows coding guidelines: master / 3.2.x, 3.1.x
  • Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB3-14844

…bcode.html

hanakin
hanakin requested changes Nov 1, 2016
View reviewed changes
Copy link
Member

@hanakin hanakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swap the tags back and leave the style attributes

@iMattPro
Copy link
Member

iMattPro commented Nov 2, 2016

Yes, what @hanakin said.

@cabot
Copy link

cabot commented Nov 3, 2016 •
edited
Loading

No.
It's not in the logic of the core and there is always a bug in prosilver which doesn't display the strong/em tags.

@hanakin
Copy link
Member

hanakin commented Nov 3, 2016

  1. Core 100% uses bbcode.html, the code in core u keep referring to is a deprecated function. The entirety of bbcode.php was re-written for 3.2
  2. The bug you are referring to has nothing to do with core but with the placement of the transposed HTML within prosilvers shitty dom. Basically if it falls within a parent of .row it fucks up. Which is everywhere outside of a post

marc1706
marc1706 requested changes Nov 13, 2016
View reviewed changes
phpBB/styles/prosilver/template/bbcode.html
@@ -18,14 +18,14 @@
<!-- BEGIN inline_attachment_open --><div class="inline-attachment"><!-- END inline_attachment_open -->
<!-- BEGIN inline_attachment_close --></div><!-- END inline_attachment_close -->

<!-- BEGIN b_open --><strong><!-- END b_open -->
<!-- BEGIN b_close --></strong><!-- END b_close -->
<!-- BEGIN b_open --><span style="font-weight: bold"><!-- END b_open -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change these back to strong with the added stylesheet.

phpBB/styles/prosilver/template/bbcode.html

<!-- BEGIN u_open --><span style="text-decoration: underline"><!-- END u_open -->
<!-- BEGIN u_close --></span><!-- END u_close -->

<!-- BEGIN i_open --><em><!-- END i_open -->
<!-- BEGIN i_close --></em><!-- END i_close -->
<!-- BEGIN i_open --><span style="font-style: italic"><!-- END i_open -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use em with the added stylesheet.

@marc1706
Copy link
Member

Added pending closure label as PR hasn't seen any activity since November.

@marc1706 marc1706 closed this Mar 19, 2017
@marc1706 marc1706 mentioned this pull request Mar 19, 2017
Merged
4 tasks
@Skouat Skouat deleted the ticket/14844 branch March 19, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanakin hanakin hanakin requested changes

@marc1706 marc1706 marc1706 requested changes

Assignees
No one assigned
Labels
Pending Closure 🔒 WIP 🚧
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Skouat @iMattPro @cabot @hanakin @marc1706