[ticket/14842] Don't display filesize limit if there is none #4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc1706
reviewed
Nov 13, 2016
| $user->lang('PIXELS', (int) $config['avatar_max_width']), | ||
| $user->lang('PIXELS', (int) $config['avatar_max_height']), | ||
| round($config['avatar_filesize'] / 1024)); | ||
| round($config['avatar_filesize'] / 1024); |
There was a problem hiding this comment.
Seems like this was removed by accident?
Nicofuma
reviewed
Nov 14, 2016
| @@ -1924,7 +1924,7 @@ function main($id, $mode) | |||
|
|
|||
| 'S_FORM_ENCTYPE' => ' enctype="multipart/form-data"', | |||
|
|
|||
| 'L_AVATAR_EXPLAIN' => sprintf($user->lang['AVATAR_EXPLAIN'], $config['avatar_max_width'], $config['avatar_max_height'], $config['avatar_filesize'] / 1024), | |||
| 'L_AVATAR_EXPLAIN' => sprintf($user->lang[($config['avatar_filesize'] == 0) ? 'AVATAR_EXPLAIN_NO_FILESIZE' : 'AVATAR_EXPLAIN'], $config['avatar_max_width'], $config['avatar_max_height'], $config['avatar_filesize'] / 1024), | |||
There was a problem hiding this comment.
while you are at it, please replace the usage of sprintf + the lang array by the lang method.
And split it into 2 lines.
marc1706
added a commit
to marc1706/phpbb
that referenced
this pull request
Nov 20, 2016
[ticket/14842] Don't display filesize limit if there is none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket (set the ticket ID to your ticket ID):
https://tracker.phpbb.com/browse/PHPBB3-14842
PHPBB3-14842