Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/11989] Rationalize overall_header_navigation* events #4521

Closed
wants to merge 1 commit into from

Conversation

senky
Copy link
Contributor

@senky senky commented Nov 20, 2016

Checklist:

  • Correct branch: master for new features; 3.2.x, 3.1.x for fixes
  • Tests pass
  • Code follows coding guidelines: master / 3.2.x, 3.1.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-11989

PHPBB3-11989

@iMattPro
Copy link
Member

iMattPro commented Nov 20, 2016

This is a bad change. It's too late for this (it was proposed while 3.1 was still in development).

You can't move template events around now.

Especially one's as widely used and important as these. This will affect a lot of extensions.

Instead you should add new template events in the locations where you moved the existing ones to.

@DavidIQ
Copy link
Member

DavidIQ commented Nov 20, 2016

+1 agree it's too late to be moving events around. 3.3 should bring about a new default template so it'll be more appropriate there.

@senky senky closed this Nov 20, 2016
@senky senky deleted the ticket/11989 branch January 23, 2017 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants