[ticket/14895] CLI should use SymfonyStyle #4564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc1706
requested changes
Dec 8, 2016
| * | ||
| * @param InputInterface $input | ||
| * @param OutputInterface $output | ||
| * @return integer | ||
| */ | ||
| protected function execute(InputInterface $input, OutputInterface $output) | ||
| { | ||
| $output->writeln('<info>' . implode(', ', $this->reparser_names) . '</info>'); | ||
| $output->writeln('<info>' . $this->user->lang('CLI_DESCRIPTION_REPARSER_AVAILABLE') . '</info>'); |
There was a problem hiding this comment.
Please use the new SymfonyStyle in here: http://symfony.com/blog/new-in-symfony-2-8-console-style-guide
PHPBB3-14895
|
This should be a 3.2.x branch. Was a mistake (it defaulted to master) |
marc1706
approved these changes
Dec 8, 2016
PHPBB3-14895
PHPBB3-14895
iMattPro
changed the title
PHPBB3-14895
Nicofuma
reviewed
Dec 11, 2016
| @@ -17,7 +17,7 @@ | |||
| /** @var \phpbb\config\config */ | |||
| protected $config; | |||
|
|
|||
| function __construct(\phpbb\user $user, \phpbb\config\config $config) | |||
| public function __construct(\phpbb\user $user, \phpbb\config\config $config) | |||
Nicofuma
added a commit
to Nicofuma/phpbb
that referenced
this pull request
Dec 11, 2016
[ticket/14895] CLI should use SymfonyStyle * VSEphpbb/ticket/14895: [ticket/14895] Fix broken tests [ticket/14895] Fix issues in CLI classes [ticket/14895] Use SymfonyStyle in all CLI [ticket/14895] Use SymfonyIO styling [ticket/14895] CLI reparser:list should display proper list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
https://tracker.phpbb.com/browse/PHPBB3-14895
PHPBB3-14895