[ticket/14677] Add exclamation mark to outdated extensions #4944
Conversation
phpBB/adm/style/acp_ext_list.html
Outdated
| @@ -77,6 +78,7 @@ | |||
| <td style="text-align: center;"> | |||
| <!-- IF disabled.S_VERSIONCHECK --> | |||
| <strong <!-- IF disabled.S_UP_TO_DATE -->style="color: #228822;"<!-- ELSE -->style="color: #BC2A4D;"<!-- ENDIF -->>{disabled.META_VERSION}</strong> | |||
| <!-- IF not disabled.S_UP_TO_DATE --><i class="fa fa-exclamation-circle" aria-hidden="true"></i><!-- ENDIF --> | |||
There was a problem hiding this comment.
Yeah but add a unique class maybe "disabled-ext-icon" and color it in admin.css pls
There was a problem hiding this comment.
To be honest, I almost believe that it looks good as it is because the red looks just... a bit weird there, IMHO. What do you think?
There was a problem hiding this comment.
For me, the red is better attracting user attention.
PHPBB3-14677
|
I will look at it tomorrow after my travels, but post the screenshots here rather than on the ticket |
|
@hanakin Thank you, take your time. :) |
phpBB/adm/style/acp_ext_list.html
Outdated
| @@ -52,6 +52,7 @@ | |||
| <td style="text-align: center;"> | |||
| <!-- IF enabled.S_VERSIONCHECK --> | |||
| <strong <!-- IF enabled.S_UP_TO_DATE -->style="color: #228822;"<!-- ELSE -->style="color: #BC2A4D;"<!-- ENDIF -->>{enabled.META_VERSION}</strong> | |||
There was a problem hiding this comment.
Can we also do something about these inline styles? I would prefer to see a class used here, the same class used to style the icon color, so maybe just rename the class outdated-ext and use it for the text and the icon.
PHPBB3-14677
|
@hanakin In case you didn't see the screenshot because it's now more or less hidden in an discussion about outdated changes, see here:
|
|
looks good |
[ticket/14677] Add exclamation mark to outdated extensions
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB3-14677