Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/15863] Add core.viewforum_modify_sort_direction #5436

Merged
merged 1 commit into from Nov 18, 2018

Conversation

@3D-I
Copy link
Contributor

commented Nov 1, 2018

PHPBB3-15863

Checklist:

  • Correct branch: master for new features; 3.2.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.2.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-15863

@3D-I

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2018

!set Event

@3D-I 3D-I closed this Nov 1, 2018
@3D-I 3D-I reopened this Nov 1, 2018
@3D-I

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2018

I don't know the reason of such failure.

@toxyy

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

Perhaps the array should be on one line, as in this event?:

https://github.com/phpbb/phpbb/blob/master/phpBB/includes/functions_admin.php#L2340

@kasimi

This comment has been minimized.

Copy link
Member

commented Nov 1, 2018

The trailing comma is missing: 'direction',

@3D-I

This comment has been minimized.

Copy link
Contributor Author

commented Nov 2, 2018

Without a comma on a line and with a comma otherwise, both correct... a little confusing.

@3D-I 3D-I closed this Nov 2, 2018
@3D-I 3D-I reopened this Nov 2, 2018
@kasimi

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

That's what phpBB's event exporter expects.

phpBB/viewforum.php Outdated Show resolved Hide resolved
@marc1706 marc1706 added this to the 3.2.5 milestone Nov 11, 2018
marc1706 added a commit to marc1706/phpbb that referenced this pull request Nov 18, 2018
[ticket/15863] Add core.viewforum_modify_sort_direction
PHPBB3-15863
@marc1706

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

Rebased on 3.2.x and squashed commits.

marc1706 added a commit to marc1706/phpbb that referenced this pull request Nov 18, 2018
[ticket/15863] Add core.viewforum_modify_sort_direction
@marc1706 marc1706 merged commit 2e83153 into phpbb:3.2.x Nov 18, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@3D-I 3D-I deleted the 3D-I:ticket/15863 branch Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.