[ticket/10161] all "e-mail" strings in language files changed to "email" #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to Oleg's comment: email is preferred by RFCs and probably the way of the future PHPBB3-10161
|
+1 |
|
Should probably add a note about that to coding guidelines as well. |
|
I was not sure wether it should be included in this PR, or to create new PR for it. I can include it if you want... |
|
Should be added to this pull request im my opinion. Otherwise this pull request is incomplete. |
|
Note to coding-guidelines.html added. |
|
Yeah, that looks good. |
|
Commit message in p@8c86085 exceeds 79 chars unfortunately. |
PHPBB3-10161
|
I have updated it. Now it should be ok. |
p
added a commit
to p/phpbb3
that referenced
this pull request
Apr 27, 2012
* Senky/ticket/10161: [ticket/10161] added fullstop to the end of sentence [ticket/10161] coding-guidelines.html updated [ticket/10161] all "e-mail" strings in language files changed to "email"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to Oleg's comment:
email is preferred by RFCs and probably the way of the future
http://tracker.phpbb.com/browse/PHPBB3-10161
PHPBB3-10161