Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 7.4 shell-less commands #8

Closed
g105b opened this issue Aug 19, 2019 · 1 comment
Closed

Support for PHP 7.4 shell-less commands #8

g105b opened this issue Aug 19, 2019 · 1 comment

Comments

@g105b
Copy link
Member

g105b commented Aug 19, 2019

Here is the changelog for 7.4: https://github.com/php/php-src/blob/PHP-7.4/UPGRADING#L323

A problem that has been encountered within this repository is when executing sub-scripts. If a new script is executed, its PID has to be held reference to so that it can be manually killed if the script dies. If the program crashes, it's possible to leave zombie processes running.

Starting a process using the array syntax removes the sub-shell execution, allowing PHP to properly maintain its child processes.

@g105b
Copy link
Member Author

g105b commented Mar 27, 2021

Implemented. Pass either a string or an array of strings.

@g105b g105b closed this as completed Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant