Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

bug #4104 Can't edit updatable view when searching

  • Loading branch information...
commit 111923f61c991f869ad4102397c165fe8f2dac85 1 parent c693975
@lem9 lem9 authored
Showing with 3 additions and 3 deletions.
  1. +1 −0  ChangeLog
  2. +2 −3 sql.php
View
1  ChangeLog
@@ -2,6 +2,7 @@ phpMyAdmin - ChangeLog
======================
4.0.9.0 (not yet released)
+- bug #4104 Can't edit updatable view when searching
4.0.8.0 (not yet released)
- bug #3988 Rename view is not working
View
5 sql.php
@@ -1237,10 +1237,9 @@
// hide edit and delete links:
// - for information_schema
// - if the result set does not contain all the columns of a unique key
- // and we are not just browing all the columns of an updatable view
+ // (unless this is an updatable view)
$updatableView
- = $justBrowsing
- && trim($analyzed_sql[0]['select_expr_clause']) == '*'
+ = trim($analyzed_sql[0]['select_expr_clause']) == '*'
&& PMA_Table::isUpdatableView($db, $table);
$editable = $resultSetContainsUniqueKey || $updatableView;
if (!empty($table) && (PMA_is_system_schema($db) || !$editable)) {
Please sign in to comment.
Something went wrong with that request. Please try again.