Skip to content

Commit

Permalink
Recent MySQL manual versions are not translated, so lets drop this op…
Browse files Browse the repository at this point in the history 
…tion
  • Loading branch information
@nijel
nijel committed Sep 6, 2012
1 parent 58491a4 commit 1d2462b
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions libraries/CommonFunctions.class.php
View file
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -536,16 +536,10 @@ public function showMySQLDocu(
if (defined('PMA_MYSQL_INT_VERSION')) { if (defined('PMA_MYSQL_INT_VERSION')) {
if (PMA_MYSQL_INT_VERSION >= 50500) { if (PMA_MYSQL_INT_VERSION >= 50500) {
$mysql = '5.5'; $mysql = '5.5';
/* l10n: Please check that translation actually exists. */
$lang = _pgettext('MySQL 5.5 documentation language', 'en');
} else if (PMA_MYSQL_INT_VERSION >= 50100) { } else if (PMA_MYSQL_INT_VERSION >= 50100) {
$mysql = '5.1'; $mysql = '5.1';
/* l10n: Please check that translation actually exists. */
$lang = _pgettext('MySQL 5.1 documentation language', 'en');
} else { } else {
$mysql = '5.0'; $mysql = '5.0';

This comment has been minimized.

Sign in to view

Copy link
@roccivic

roccivic Sep 6, 2012

Contributor

In the current state of the code there is no need for this else statement, the default version is already 5.0.
This, however, is weird as I doubt many people are still running that version. I, personally, would set the default to the latest version.

This comment has been minimized.

Sign in to view

Copy link
@nijel

nijel Sep 6, 2012

Author Contributor

Indeed the else part is not needed...
/* l10n: Please check that translation actually exists. */
$lang = _pgettext('MySQL 5.0 documentation language', 'en');
} }
} }
$url = $cfg['MySQLManualBase'] $url = $cfg['MySQLManualBase']
Expand Down

0 comments on commit 1d2462b

Please sign in to comment.