Skip to content

Commit

Permalink
Improve Charsets class unit tests
Browse files Browse the repository at this point in the history 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
  • Loading branch information
@MauricioFauth
MauricioFauth committed Feb 21, 2022
1 parent fbbc246 commit 20c6842
Showing 1 changed file with 76 additions and 42 deletions.
118 changes: 76 additions & 42 deletions test/classes/CharsetsTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

/**
* @covers \PhpMyAdmin\Charsets
* @runTestsInSeparateProcesses
*/
class CharsetsTest extends AbstractTestCase
{
Expand All @@ -17,74 +18,107 @@ protected function setUp(): void
parent::setGlobalDbi();
$GLOBALS['server'] = 0;
$GLOBALS['cfg']['DBG']['sql'] = false;
$GLOBALS['cfg']['Server']['DisableIS'] = false;
}

public function testGetServerCharset(): void
{
$this->dummyDbi->addResult(
'SHOW SESSION VARIABLES LIKE \'character_set_server\';',
[
[
'character_set_server',
'utf8mb3',
],
],
[
'Variable_name',
'Value',
]
[['character_set_server', 'utf8mb3']],
['Variable_name', 'Value']
);
$this->dummyDbi->addResult('SHOW SESSION VARIABLES LIKE \'character_set_server\';', false);
$this->dummyDbi->addResult('SELECT @@character_set_server;', false);
$this->dummyDbi->addResult('SHOW SESSION VARIABLES LIKE \'character_set_server\';', false);
$this->dummyDbi->addResult('SELECT @@character_set_server;', [['utf8mb3']]);
$this->dummyDbi->addResult(
'SELECT @@character_set_server;',
[
['utf8mb3'],
]
'SHOW SESSION VARIABLES LIKE \'character_set_server\';',
[['character_set_server', 'utf8mb4']],
['Variable_name', 'Value']
);

$charset = Charsets::getServerCharset($GLOBALS['dbi'], $GLOBALS['cfg']['Server']['DisableIS']);
$charset = Charsets::getServerCharset($this->dbi, false);
$this->assertSame('utf8', $charset->getName());

$charset = Charsets::getServerCharset($GLOBALS['dbi'], $GLOBALS['cfg']['Server']['DisableIS']);
$charset = Charsets::getServerCharset($this->dbi, false);
$this->assertSame('Unknown', $charset->getName());

$charset = Charsets::getServerCharset($GLOBALS['dbi'], $GLOBALS['cfg']['Server']['DisableIS']);
$charset = Charsets::getServerCharset($this->dbi, false);
$this->assertSame('utf8', $charset->getName());

$charset = Charsets::getServerCharset($this->dbi, false);
$this->assertSame('utf8mb4', $charset->getName());

$charset = Charsets::getServerCharset($this->dbi, false);
$this->assertSame('utf8mb4', $charset->getName());

$this->assertAllQueriesConsumed();
}

public function testFindCollationByName(): void
{
$this->assertNull(Charsets::findCollationByName(
$GLOBALS['dbi'],
$GLOBALS['cfg']['Server']['DisableIS'],
null
));

$this->assertNull(Charsets::findCollationByName(
$GLOBALS['dbi'],
$GLOBALS['cfg']['Server']['DisableIS'],
''
));

$this->assertNull(Charsets::findCollationByName(
$GLOBALS['dbi'],
$GLOBALS['cfg']['Server']['DisableIS'],
'invalid'
));

$actual = Charsets::findCollationByName(
$GLOBALS['dbi'],
$GLOBALS['cfg']['Server']['DisableIS'],
'utf8_general_ci'
$this->assertNull(Charsets::findCollationByName($this->dbi, false, null));
$this->assertNull(Charsets::findCollationByName($this->dbi, false, ''));
$this->assertNull(Charsets::findCollationByName($this->dbi, false, 'invalid'));
$actual = Charsets::findCollationByName($this->dbi, false, 'utf8_general_ci');
$this->assertInstanceOf(Charsets\Collation::class, $actual);
$this->assertSame('utf8_general_ci', $actual->getName());
}

public function testGetCharsetsWithIS(): void
{
$charsets = Charsets::getCharsets($this->dbi, false);
$this->assertCount(4, $charsets);
$this->assertContainsOnlyInstancesOf(Charsets\Charset::class, $charsets);
}

public function testGetCharsetsWithoutIS(): void
{
$this->dummyDbi->addResult(
'SHOW CHARACTER SET',
[
['armscii8', 'ARMSCII-8 Armenian', 'armscii8_general_ci', '1'],
['utf8', 'utf8_general_ci', 'UTF-8 Unicode', '3'],
['utf8mb4', 'UTF-8 Unicode', 'utf8mb4_0900_ai_ci', '4'],
['latin1', 'latin1_swedish_ci', 'cp1252 West European', '1'],
],
['Charset', 'Default collation', 'Description', 'Maxlen']
);

$this->assertInstanceOf(Charsets\Collation::class, $actual);
$charsets = Charsets::getCharsets($this->dbi, true);
$this->assertCount(4, $charsets);
$this->assertContainsOnlyInstancesOf(Charsets\Charset::class, $charsets);
}

$this->assertSame('utf8_general_ci', $actual->getName());
public function testGetCollationsWithIS(): void
{
$collations = Charsets::getCollations($this->dbi, false);
$this->assertCount(4, $collations);
$this->assertContainsOnly('array', $collations);
foreach ($collations as $collation) {
$this->assertContainsOnlyInstancesOf(Charsets\Collation::class, $collation);
}
}

public function testGetCollationsWithoutIS(): void
{
$this->dummyDbi->addResult(
'SHOW COLLATION',
[
['utf8mb4_general_ci', 'utf8mb4', '45', 'Yes', 'Yes', '1'],
['armscii8_general_ci', 'armscii8', '32', 'Yes', 'Yes', '1'],
['utf8_general_ci', 'utf8', '33', 'Yes', 'Yes', '1'],
['utf8_bin', 'utf8', '83', '', 'Yes', '1'],
['latin1_swedish_ci', 'latin1', '8', 'Yes', 'Yes', '1'],
],
['Collation', 'Charset', 'Id', 'Default', 'Compiled', 'Sortlen']
);

$collations = Charsets::getCollations($this->dbi, true);
$this->assertCount(4, $collations);
$this->assertContainsOnly('array', $collations);
foreach ($collations as $collation) {
$this->assertContainsOnlyInstancesOf(Charsets\Collation::class, $collation);
}
}
}

0 comments on commit 20c6842

Please sign in to comment.